Skip to content

fix(action): rewrite legacy skill names in prompt - #98

Closed
tend-agent wants to merge 1 commit into
mainfrom
hourly/review-23697186268
Closed

tend-agent wants to merge 1 commit into
mainfrom
hourly/review-23697186268

Conversation

@tend-agent

Copy link
Copy Markdown
Collaborator

Summary

  • Add a prompt normalization step in action.yaml that rewrites legacy skill
    names (/tend:tend-* → /tend-ci-runner:*) before passing to Claude Code

Evidence

Critical finding — 8+ occurrences. Both tend-review runs on PRQL/prql
this hour (runs
23694627681,
23694428832) failed
with Unknown skill: tend:tend-review. The sessions lasted <1 second, no
review was posted, yet the jobs reported success. PR
PRQL/prql#5753 and PR
PRQL/prql#5752 were both merged
without bot review.

6+ additional occurrences were recorded in tracking issue #12 across prior
hourly runs (worktrunk and PRQL/prql). PR #54 attempted a compat plugin
approach but was closed.

Root cause

The plugin rename from tend → tend-ci-runner in #39 changed skill names
(tend-review → review). The generator was updated to emit
/tend-ci-runner:review, but adopter repos whose workflows were generated
before v0.0.2 still reference /tend:tend-review.

Fix

A lightweight prompt rewrite step: ${PROMPT//\/tend:tend-/\/tend-ci-runner:}.
This runs before claude-code-action and transparently maps old names to new
ones. No compat plugin needed, no changes required in adopter repos.

Gate assessment

  • Evidence level: Critical (reviews silently skipped, PRs merged unreviewed)
  • Occurrences: 8+ (2 this hour + 6+ historical in review-reviewers tracking: 2026-03 #12)
  • Change type: Targeted fix (one new step in action.yaml)
  • Passes both gates: Yes

Test plan

  • CI passes on this PR
  • After merging and updating the v1 tag, verify PRQL/prql tend-review
    runs load the tend-ci-runner:review skill successfully

🤖 Generated with Claude Code

Pre-v0.0.2 workflows reference /tend:tend-review (old plugin name).
The generator now emits /tend-ci-runner:review, but adopter repos
that haven't regenerated hit "Unknown skill: tend:tend-review" and
silently skip reviews. Rewrite /tend:tend-* → /tend-ci-runner:* in
the prompt before passing to claude-code-action.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@tend-agent tend-agent added the claude-behavior Behavioral issues found by review-reviewers label Mar 29, 2026
@max-sixty

Copy link
Copy Markdown
Owner

@tend-agent is this still current?

@max-sixty max-sixty closed this Apr 4, 2026
@tend-agent

Copy link
Copy Markdown
Collaborator Author

No — no longer current. Checked PRQL/prql's tend-review.yaml, which now emits /tend-ci-runner:review (regenerated post-#39). Their last three tend-review runs completed successfully. The prompt-rewrite workaround isn't needed — adopter repos have caught up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude-behavior Behavioral issues found by review-reviewers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants