Repository navigation
fix: run copy-ignored outer loop on dedicated copy pool - #1913
Merged
Merged
Conversation
The outer `.par_iter()` in `step_copy_ignored` ran on the global rayon pool (2× CPU cores), but each iteration called `copy_dir_recursive` which enters the 4-thread `COPY_POOL` and blocks. This meant many global-pool threads sat idle waiting for just 4 copy workers — effectively serializing the work. Wrap the outer loop in `copy_pool_install()` so all parallelism (top-level entries and recursive directory walks) shares the same 4-thread pool directly, matching the pre-0.33 intent of 4 concurrent copy threads across all paths. Co-Authored-By: Claude <noreply@anthropic.com>
worktrunk-bot
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The outer
.par_iter()instep_copy_ignoredran on the global rayon pool (2× CPU cores), but each iteration calledcopy_dir_recursivewhich enters the 4-threadCOPY_POOLviainstall()and blocks. This meant many global-pool threads sat idle waiting for just 4 copy workers — effectively serializing top-level entries rather than copying them in parallel.Adds
copy_pool_install()to wrap the outer loop so all parallelism (top-level entries and recursive directory walks) shares the same 4-thread pool directly. This restores the pre-0.33 behavior of 4 concurrent copy threads across all paths, without the per-folder pool creation that caused EMFILE in #1864.