Skip to content

refactor(verbose): rename output.log → subprocess.log; -vv keeps Info on stderr - #2913

Merged
max-sixty merged 1 commit into
mainfrom
verbose-cleanup
May 26, 2026
Merged

max-sixty merged 1 commit into
mainfrom
verbose-cleanup

Conversation

@max-sixty

Copy link
Copy Markdown
Owner

Motivation

The -v / -vv UX had three small issues that compounded:

  1. output.log is misnamed. It holds the uncapped raw stdout/stderr of every subprocess wt spawns — multi-MB possible (git log -p, patch-id pipelines, etc.). "output" reads as "stuff wt printed" — the small thing — when it's actually the big thing. Easy to misread.
  2. -vv went fully dark on stderr. PR refactor(log): route -vv log pipeline to trace.log instead of stderr #2892 moved the noisy debug pipeline to files at -vv; in the process, the stderr layer was disabled entirely. Users running -vv to see hook output (info-level, which -v shows on stderr) suddenly couldn't.
  3. -v help text was a 150-char one-liner packed into a parenthetical, and the surrounding docs leaned on a "stderr stays readable / log::* pipeline" framing that was Rust-jargon-flavored and implied stderr-quiet at -vv — which is no longer true after change Test CI fixes and improvements #2.

Change

  • Rename output.log → subprocess.log. Filename now matches content. OUTPUT static → SUBPROCESS, plus the related OutputMakeWriter / OutputFileFormat / build_output_layer symbol renames.
  • -vv keeps the Info baseline on stderr. build_stderr_layer no longer returns None at -vv; debug-level records still route to file layers only, so the terminal stays readable while info-level status (hook output, template variables, the Tracing to ... pointer) shows the same as at -v.
  • -v help text rewritten to describe both levels cleanly without a wall of detail.
  • docs/content/faq.md gets a "What does -v / -vv do?" section with a three-level table.
  • Docs cleanup: drop "stderr stays readable" / log::* jargon / "but not subprocess.log" negative framing from user-facing prose.

Notes for review

  • The only log::info! site in the codebase is commands/picker/mod.rs:389 (a single picker error message), so making -vv show info-level on stderr doesn't add meaningful noise.
  • test_vv_log_pipeline_silent_on_stderr is renamed to test_vv_debug_pipeline_silent_on_stderr — its assertions only check debug-level records stay out of stderr (they do); the old name implied the whole log::* pipeline was silent, which was never quite true (direct eprintln! always showed) and is less true now (info-level routes to stderr).
  • 67 of the 69 changed files are snapshot updates (help text and one diagnostic snapshot) and auto-synced doc/skill mirrors. git diff --stat -- 'tests/snapshots/*' 'docs/content/*' 'skills/worktrunk/reference/*' | tail -1 separates them.
  • CHANGELOG: not touched. The historical entry that introduced output.log (#2201) stays accurate for its release; this rename gets a new line in the next release.

Tests

3870 tests pass. Re-snapshotted all test_help_* snapshots, three step_alias snapshots that quote the global help, and the diagnostic file format snapshot.

This was written by Claude Code on behalf of max-sixty

… on stderr

output.log was misleadingly named: it's the uncapped raw stdout/stderr of every
subprocess wt spawns (multi-MB possible), not wt's own output. Rename to
subprocess.log so the filename matches the content. OUTPUT static, OutputMakeWriter,
OutputFileFormat, build_output_layer rename to match.

At -vv, the stderr layer now keeps the Info baseline instead of going fully dark —
debug-level records (commands, [wt-trace], bounded subprocess preview) still route
to trace.log only, so the terminal stays readable while -vv users see info-level
status (hook output, template variables) the same as at -v. The "stderr stays
readable / log::* pipeline" framing is dropped from docs since it implied -vv
made stderr silent.

Help text for -v rewritten as a single-line parenthetical describing both levels.
faq.md gets a new "What does -v / -vv do?" section laying out the three levels.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@max-sixty
max-sixty merged commit 21e0b27 into main May 26, 2026
36 checks passed
@max-sixty
max-sixty deleted the verbose-cleanup branch May 26, 2026 18:55
@max-sixty max-sixty mentioned this pull request May 26, 2026
max-sixty added a commit that referenced this pull request May 26, 2026
v0.54.0.

`cargo semver-checks` reports 3 breaking library API changes
(`shell_exec::set_output_log_available` removed,
`SUBPROCESS_TERMINAL_TARGET` removed, `Deprecations::{pre_start,
post_start}` removed) — none of them intentional API, but they force
minor pre-1.0.

Headline user-visible changes:
- New rate-limit pace segment in the Claude Code statusline (#2899,
#2911).
- `wt step prune` streams removals and skips unapproved hooks instead of
prompting mid-scan; default `--min-age` raised 1h → 1d (#2908, #2910,
#2886).
- `-vv` no longer floods stderr — debug routes to `trace.log`, Info
stays on stderr; raw subprocess sink renamed `output.log` →
`subprocess.log`; `RUST_LOG` honored at every verbosity level (#2892,
#2901, #2913).
- Data-safety fixes across merge / remove / prune lifecycle (#2870).
- Legacy shell-wrapper deprecation warning (#2880).

Full CHANGELOG entry in this PR.
max-sixty added a commit that referenced this pull request May 27, 2026
… rename (#2919)

## Motivation

Follow-up cleanup surfaced after #2913 landed:

1. The `-vv` startup pointer listed `trace.log` and `subprocess.log` but
never mentioned `diagnostic.md`, even though the gist-creation hint at
exit points specifically at `diagnostic.md`. Users had no idea the
bundle existed until exit.
2. The Jinja template field `output_log_path` and a test local
`output_log` lagged behind the file rename in #2913 — values were
correct but names disagreed.
3. While reshaping the pointer, the "Tracing to ..." verb read awkwardly
("Writing to ..." is more natural for "files are being written here").

## Change

- `src/logging.rs:490` — `announce_trace_destination` now prints the
shared log directory once and lists all three files:

  ```
  ○ Writing to ~/.../wt/logs/ — trace.log, subprocess.log, diagnostic.md
  ```

(When `subprocess.log` failed to open: `… — trace.log, diagnostic.md
(subprocess.log unavailable)`.) `diagnostic.md` is named at startup even
though it's written at exit — by the time a user reads the pointer and
looks for files, all three are there.

- `src/diagnostic.rs` — `output_log_path` Jinja field + Rust local
renamed to `subprocess_log_path`. Dropped the trailing `— not inlined
because it can be multi-MB` clause from the template (matches the
principle from #2913's review: describe what's there, not what isn't).

- `tests/integration_tests/diagnostic.rs:315` — local `output_log` →
`subprocess_log`.

- Diagnostic snapshot re-accepted for the template wording change.

## Tests

3875 tests pass + lints + doctests. Pointer wording change is covered by
`test_vv_debug_pipeline_silent_on_stderr` and
`test_vv_pointer_handles_split_init`, both updated to assert "Writing
to".

> _This was written by Claude Code on behalf of max-sixty_

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
max-sixty added a commit that referenced this pull request May 27, 2026
…pointer (#2924)

The 0.54.0 entry for #2913 quoted the `-vv` startup pointer as `Tracing
to …`, but #2919 (also in 0.54.0) renamed it to `Writing to …`. Fix the
entry to match the shipped behavior.

Caught by worktrunk-bot on #2919.

> _This was written by Claude Code on behalf of max-sixty_

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
worktrunk 0.54.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## Release Notes

### Improved

- **Rate-limit pace segment in the Claude Code statusline**: `wt list statusline --format=claude-code` now surfaces a yellow `1.3×pace(10am–3pm)` segment when Claude Code's reported five-hour or seven-day rate-limit window is on track to be hit before its reset. The segment uses a Bayesian forecast on `P(final ≥ 100%)` so early-window bursts (e.g., 5% used at 3% elapsed) don't trigger spurious warnings — only the worse-projected of the two windows is shown, and the segment is hidden entirely when both are safe. The clock format inside the parentheses honors `LC_ALL` / `LC_TIME` / `LANG`: `en_US`/`en_PH`/`en_CA` get 12-hour (`10am–3pm`), everything else (including unset and `C`/`POSIX`) gets 24-hour (`10:00–15:00`). ([#2899](max-sixty/worktrunk#2899), [#2911](max-sixty/worktrunk#2911))

- **`wt step prune` streams removals and never prompts mid-scan**: Prune now bundles integration, removability, and age checks into a single parallel pass and starts removing candidates as soon as they qualify, instead of batching the scan and acting at the end. Dirty / locked / primary worktrees drop out before the age check, so a young + dirty + integrated worktree no longer surfaces as `Skipped (younger than 1d)` — the `(younger than X)` message now fires only when the worktree would actually have been pruned. With `--yes`, every project command is auto-approved as before; without `--yes`, a candidate whose hooks include an unapproved project command is SKIPPED with `(approval required)` rather than aborting the scan with an inline prompt the streaming structure couldn't accommodate. The end-of-run hint enumerates the unapproved hook templates from the invoking worktree's config and emits one copy-pasteable `wt -C <path> remove` line per skipped candidate, annotating candidates whose own `.config/wt.toml` differs from the invoking worktree's. ([#2908](max-sixty/worktrunk#2908), [#2910](max-sixty/worktrunk#2910))

- **`wt step prune` default `--min-age` raised from 1h to 1d**: A worktree just created from the default branch looks "merged" because its branch still points at the same commit; a one-day floor keeps an unattended prune from sweeping it up before its owner starts work. Explicit `--min-age=0s` or any other value is unchanged. ([#2886](max-sixty/worktrunk#2886))

- **Legacy shell-wrapper deprecation warning**: Users who upgrade `wt` without restarting their shell still run the previous release's wrapper, which sets only `WORKTRUNK_DIRECTIVE_FILE` instead of the new split `WORKTRUNK_DIRECTIVE_CD_FILE` / `WORKTRUNK_DIRECTIVE_EXEC_FILE` pair. That fallback used to be silent; `wt` now emits a one-shot per-process warning hinting at `wt config shell install`. bash, zsh, fish, and PowerShell pick up the new wrapper on the next shell restart; nushell is the one shell where users must rerun `wt config shell install nu` because its wrapper is a static file. ([#2880](max-sixty/worktrunk#2880))

- **`-vv` no longer floods stderr; raw subprocess sink renamed to `subprocess.log`**: A `-vv` invocation used to spray ~15K lines of stderr per command, forcing a redirect to a file even though `trace.log` already mirrored most of it. The debug-level `log::*` pipeline now writes to `.git/wt/logs/trace.log` at `-vv`; Info-level records (hook output, template expansions, the `Tracing to …` pointer) stay on stderr at every verbosity level. The companion raw-subprocess-bytes file is renamed from `output.log` to `subprocess.log` — the prior name read as "stuff `wt` printed" but actually held uncapped multi-MB subprocess bodies (`git log -p`, patch-id pipelines). `RUST_LOG` is now honored at every verbosity level: `wt -v` and `wt -vv` previously hardcoded Info / Debug and silently dropped any `RUST_LOG` directive (`RUST_LOG=trace wt -vv` was capped at Debug, `RUST_LOG=worktrunk=trace wt -v` was ignored); all three levels now flow through one builder shape with `RUST_LOG` layered on top of the flag baseline. ([#2892](max-sixty/worktrunk#2892), [#2901](max-sixty/worktrunk#2901), [#2913](max-sixty/worktrunk#2913))

### Fixed

- **Data-safety across the worktree merge / remove / prune lifecycle**: Five TOCTOU and scoping fixes. `wt merge` and `wt remove` revalidate cleanliness and branch integration *after* `pre-remove` hooks run, so a hook (or concurrent process) that dirties the worktree or advances the branch can no longer trash the directory or trigger `git branch -D` against the stale pre-hook decision. The background-removal path does the same revalidation and fails closed for submodule worktrees on the fallback path instead of forcing. `wt step prune` runs its rename-failure fallback `git branch -d` synchronously under the write guard for non-current worktrees (no more race against live integration readers on `.git/config`), scopes hook approval to the worktrees it will actually remove (an unrelated unapproved hook can no longer abort a non-interactive prune), and prunes the stale metadata of detached worktrees whose directory was deleted outside Worktrunk. ([#2870](max-sixty/worktrunk#2870))

### Documentation

- **`-v` / `-vv` help and FAQ**: The `-v` help text is split out from its 150-character parenthetical, and `docs/content/faq.md` gains a "What does `-v` / `-vv` do?" section with a three-level table. ([#2913](max-sixty/worktrunk#2913))

- **Hook docs and `pre-start` docstring**: The `pre_create` field docstring in `HooksConfig` (user-visible via generated JSON schema) read "Commands to execute before worktree creation"; `pre-start` actually runs *after* worktree creation, blocking. Restored the correct wording. The `docs/content/extending.md` overview is reworked to read more cleanly: parallel three-paragraph intro for hooks / aliases / custom subcommands, fewer em-dashes, and the Reference section's table no longer duplicates content covered in prose. ([#2879](max-sixty/worktrunk#2879), [#2912](max-sixty/worktrunk#2912))

### Internal

- **Migrated logging from `env_logger` to `tracing-subscriber`**: A layered subscriber routes records structurally by target and verbosity. Existing `log::*` callers are bridged into `tracing` via `tracing_log::LogTracer`. `[wt-trace]` records emit as typed structured fields with a single formatter rendering the wire shape, so the grammar lives in one place instead of being duplicated across every emit site.

- **`UncommittedChanges` error renders dirty files in the canonical gutter**, matching `ConflictingChanges` and the project's `format_with_gutter()` convention. ([#2887](max-sixty/worktrunk#2887))

## Install worktrunk 0.54.0

### Install prebuilt binaries via shell script

```sh
curl --proto '=https' --tlsv1.2 -LsSf https://github.com/max-sixty/worktrunk/releases/download/v0.54.0/worktrunk-installer.sh | sh && wt config shell install
```

### Install prebuilt binaries via powershell script

```sh
powershell -ExecutionPolicy Bypass -c "irm https://github.com/max-sixty/worktrunk/releases/download/v0.54.0/worktrunk-installer.ps1 | iex"; git-wt config shell install
```

### Install prebuilt binaries via Homebrew

```sh
brew install worktrunk && wt config shell install
```

## Download worktrunk 0.54.0

|  File  | Platform | Checksum |
|--------|----------|----------|
| [worktrunk-aarch64-apple-darwin.tar.xz](https://github.com/max-sixty/worktrunk/releases/download/v0.54.0/worktrunk-aarch64-apple-darwin.tar.xz) | Apple Silicon macOS | [checksum](https://github.com/max-sixty/worktrunk/releases/download/v0.54.0/worktrunk-aarch64-apple-darwin.tar.xz.sha256) |
| [worktrunk-x86_64-apple-darwin.tar.xz](https://github.com/max-sixty/worktrunk/releases/download/v0.54.0/worktrunk-x86_64-apple-darwin.tar.xz) | Intel macOS | [checksum](https://github.com/max-sixty/worktrunk/releases/download/v0.54.0/worktrunk-x86_64-apple-darwin.tar.xz.sha256) |
| [worktrunk-x86_64-pc-windows-msvc.zip](https://github.com/max-sixty/worktrunk/releases/download/v0.54.0/worktrunk-x86_64-pc-windows-msvc.zip) | x64 Windows | [checksum](https://github.com/max-sixty/worktrunk/releases/download/v0.54.0/worktrunk-x86_64-pc-windows-msvc.zip.sha256) |
| [worktrunk-aarch64-unknown-linux-musl.tar.xz](https://github.com/max-sixty/worktrunk/releases/download/v0.54.0/worktrunk-aarch64-unknown-linux-musl.tar.xz) | ARM64 MUSL Linux | [checksum](https://github.com/max-sixty/worktrunk/releases/download/v0.54.0/worktrunk-aarch64-unknown-linux-musl.tar.xz.sha256) |
| [worktrunk-x86_64-unknown-linux-musl.tar.xz](https://github.com/max-sixty/worktrunk/releases/download/v0.54.0/worktrunk-x86_64-unknown-linux-musl.tar.xz) | x64 MUSL Linux | [checksum](https://github.com/max-sixty/worktrunk/releases/download/v0.54.0/worktrunk-x86_64-unknown-linux-musl.tar.xz.sha256) |



### Install via Cargo

```sh
cargo install worktrunk && wt config shell install
```

### Install via Winget (Windows)

```sh
winget install max-sixty.worktrunk && git-wt config shell install
```

### Install via AUR (Arch Linux)

```sh
paru worktrunk-bin && wt config shell install
```
</pre>
  <p>View the full release notes at <a href="https://github.com/max-sixty/worktrunk/releases/tag/v0.54.0">https://github.com/max-sixty/worktrunk/releases/tag/v0.54.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!7938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants