Repository navigation
ci: run lib tests across the feature powerset in nightly - #3059
Conversation
The nightly feature-powerset job only checks production code (--no-dev-deps), so #[cfg(test)] code is never compiled per combo. Two breaks existed on main: cargo test --lib --no-default-features didn't compile (two styling tests call format_bash_with_gutter_at_width, which is imported only under syntax-highlighting), and once compiling, six tests failed because their assertions/snapshots bake in highlighted output. Add cargo hack test --feature-powerset --lib as a second step on the job, and gate the affected tests on syntax-highlighting. Also gate test_no_bold_dim_conflict, which has only negative assertions and passed vacuously without the feature. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
worktrunk-bot
left a comment
There was a problem hiding this comment.
The new cargo hack test --feature-powerset --lib step fails in CI — combo 1/20 (cargo test --lib --no-default-features) panics in testing::mock_commands::tests::test_mock_config_write:
mock-stub binary not found at .../target/debug/mock-stub
This is the gotcha the mock_stub_binary docstring in src/testing/mock_commands.rs already calls out: workspace.default-members builds mock-stub only under an unfiltered cargo test — --lib is a target filter, which overrides default-members, so the helper bin is never built. The local "all 20 combos pass" run succeeded because target/debug/mock-stub was already present from a prior unfiltered build; a clean CI runner has no such artifact. test_mock_config_write isn't feature-gated, so every combo hits it and the run aborts on the first.
Building the helper bin once before the powerset loop fixes it for all 20 combos (they share target/debug/). mock-stub is a standalone crate, independent of worktrunk's feature flags, so one build suffices. The inline suggestion adds the step.
CI failed — the new feature-powerset lib-test step panics (mock-stub not built under --lib). See review comment for the fix.
--lib is a target filter, which skips the default-members helper-bin build, so test_mock_config_write panics on a fresh runner. One default build serves every combo since mock-stub doesn't depend on worktrunk features. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…#3068) Follow-up to #3059, which added a per-combination test sweep to nightly but bounded it to `--lib` (plus a separate `--doc` pass). The integration suite snapshots highlighted `wt` output, so it only passes with `syntax-highlighting` on — `--lib` was a blunt way to keep it out of the combinations that can't satisfy that. This runs the unfiltered `cargo hack test --feature-powerset` — lib, integration, and doctests per combination — and moves the scoping to where it's semantically correct, in `Cargo.toml`: - The `integration` test target declares `required-features = ["cli", "syntax-highlighting"]`. It execs the `wt` binary (needs `cli`) and snapshots its highlighted output (needs `syntax-highlighting`), so cargo runs it only on combinations that satisfy both and skips it elsewhere instead of failing. - The `git-wt` binary gets `test = false`. `git_wt.rs` is `include!("main.rs")`, so its unit tests are byte-identical duplicates of the `wt` binary's; insta derives snapshot filenames from the crate name, so the duplicates look for `git_wt__*.snap` files that don't exist (only `wt__*`). The `check` powerset still compiles the binary, so compile coverage is unchanged. Dropping the target filter also lets cargo-hack (which runs workspace-style `cargo test --manifest-path`) build the mock-stub helper bin via default-members and run doctests on its own, so the explicit `cargo build -p mock-stub` and `--doc` steps are gone. zsh/fish/nushell are installed to match the test matrix (`.github/actions/test-setup`), since the full suite now runs PTY tests on the `shell-integration-tests` combinations. Verified locally: the full 20-combination sweep is green, with integration running only on the `cli + syntax-highlighting` combinations and skipped on the rest. CI runs this job on the PR (it touches `nightly.yaml`), so the powerset exercises itself here. > _This was written by Claude Code on behalf of max_ Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
worktrunk 0.58.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## Release Notes ### Improved - **Table-form `pre-*` hooks run concurrently**: A multi-entry table hook (`[pre-merge]` with several keys) now runs its commands concurrently, completing the cut-over announced in v0.37.0: every hook type has one execution semantic, where table form is concurrent and pipeline form (`[[pre-merge]]` blocks) is serial. Configs that need ordering should use pipeline form; affected configs have warned on every invocation since v0.37.0, with `wt config update` offering a serial-preserving migration. Two adjacent inconsistencies are also gone: `wt hook <post-type>` foreground runs of multi-entry table hooks now run concurrently like their background counterpart, and single-entry table aliases write to stdout like the other alias spellings, so `wt <alias> | …` works for that spelling too. (Breaking: multi-entry table-form `pre-*` hooks no longer run serially) ([#3052](max-sixty/worktrunk#3052)) - **CI column shows the PR/MR number and review state**: The CI column in `wt list --full` and the statusline shows the branch's open PR/MR reference (`#3041` on GitHub/Gitea/Azure DevOps, `!3041` on GitLab) instead of a plain dot: colored by CI status, hyperlinked to the PR, dimmed when stale or draft. Review state folds into the color, with magenta for changes requested and cyan for awaiting review. `wt list --format=json` gains `ci.number` and `ci.review_state`. ([#3041](max-sixty/worktrunk#3041), [#3044](max-sixty/worktrunk#3044)) - **Hook and alias templates render when each step runs**: Templates are syntax-checked before the first step runs and rendered as each step executes, so `{{ vars.* }}` always reads fresh values and hooks and aliases share one expansion model. Two consequences: a pipeline step with an undefined variable fails when that step is reached (earlier steps run first), and a template error in a background hook surfaces in the hook log rather than failing the foreground command. The background runner also labels template errors the way the foreground does. ([#3042](max-sixty/worktrunk#3042), [#3047](max-sixty/worktrunk#3047)) - **`wt config state cache`**: The regenerable caches (CI status, branch summaries, git-command caches, hints, the `wt switch -` target) are consolidated under `wt config state cache`; `cache clear` drops them all without prompting, since everything regenerates. `wt config state clear`, which also wipes hand-authored markers and vars, now asks for confirmation; `--yes` skips, and non-interactive runs without `--yes` cancel. The `ci-status`, `hints`, and `previous-branch` subcommands are deprecated but still work. ([#3027](max-sixty/worktrunk#3027)) - **Statusline rate-limit segment**: Above 90% of the binding window the segment shows the used percentage (`95%(8:30am–1:30pm)`) instead of the pace ratio; near the cap, what's left matters more than the rate. The pace form drops the word "pace" (`2.9×(Tue–Tue 5pm)`), and `-vv` logs each window's inputs and selection to `.git/wt/logs/trace.log` so the binding-window choice can be reconstructed. ([#3057](max-sixty/worktrunk#3057), [#3053](max-sixty/worktrunk#3053), [#3029](max-sixty/worktrunk#3029)) - **`/wt-switch-create` branch name is optional**: The Claude Code plugin command picks a branch name from the task when none is given, and the skill's workflow is one route (create, then enter) with an error-driven fallback instead of three guarded paths. Worktrees created mid-session persist after the session ends. ([#3058](max-sixty/worktrunk#3058)) ### Fixed - **Plugin worktree hooks fail before side effects**: The Claude Code plugin's `WorktreeCreate`/`WorktreeRemove` hooks validate the payload before running `wt`; a malformed payload previously created a branch named `null` or could remove the wrong worktree. `wt remove`'s help now documents that the positional argument accepts a worktree path as well as a branch name. ([#3058](max-sixty/worktrunk#3058), [#3060](max-sixty/worktrunk#3060)) - **Waiting-for-input marker covers questions, permission prompts, and turn end**: The Claude Code plugin sets the 💬 marker on `AskUserQuestion`, permission requests, and turn end. Previously only the `Notification` event set it, which never fires for the built-in question picker (and on some platforms not for permission prompts), so the marker stayed 🤖 while Claude waited. Part of [#2916](max-sixty/worktrunk#2916). ([#3023](max-sixty/worktrunk#3023), thanks @Ismael for reporting) - **`wt list --help` no longer panics when piped**: With no detectable terminal width (output piped, `COLUMNS` unset), `wt list --help` panicked with a capacity overflow, and the post-commit diffstat truncated filenames to ~10 characters. Both now handle unknown width. ([#3040](max-sixty/worktrunk#3040)) - **Deprecation warnings match `wt config update`**: A config deprecation warning now fires exactly when `wt config update` would change the file. The old detection and migration logic had drifted in several places: `ff` and `no-ff` together silently dropped `no-ff`, a scalar `forge` key was overwritten by the `[ci]` migration, an empty `[ci] platform` migrated without warning, and an empty `approved-commands = []` could be removed by an unrelated update. ([#3055](max-sixty/worktrunk#3055)) - **Migrated `[forge]` keeps `[ci]`'s spot**: The `[ci]` → `[forge]` migration rendered the new section at the end of the file and could drop comments above `[ci]`; it now takes over `[ci]`'s position, comments included, so `wt config show` and `wt config update` diffs stay minimal. ([#3051](max-sixty/worktrunk#3051)) - **`wt config state get` is read-only**: The aggregate dump resolved (and re-cached) the default branch, so running it right after `clear` silently repopulated the cache, and on a cold clone it could hit the network. It now reports the cached value or `(none)`. `wt config state default-branch get` still resolves and caches. ([#3024](max-sixty/worktrunk#3024)) ### Documentation - **Reading vs resolving cached state**: `wt config state default-branch get` resolves and caches; the aggregate `wt config state get` only reports the cache. The help text and module docs now state the split. ([#3028](max-sixty/worktrunk#3028)) ### Internal - `wt switch`/`wt remove` orchestration moved from `main.rs` to their command modules, and the hook execution call chain lost two delegation layers. ([#3049](max-sixty/worktrunk#3049), [#3036](max-sixty/worktrunk#3036)) - Config deprecations are driven by a single rule table; each rule is one function that migrates and reports what it changed. ([#3045](max-sixty/worktrunk#3045), [#3055](max-sixty/worktrunk#3055)) - `terminal_width()` returns `Option<usize>` instead of a `usize::MAX` sentinel, making the no-width case a compile-time concern. ([#3043](max-sixty/worktrunk#3043)) - Snapshot tests regenerate identically across machines: host-specific paths are guarded, host-dependent env-block markers are normalized, and help snapshots share one settings builder. ([#3009](max-sixty/worktrunk#3009), [#3026](max-sixty/worktrunk#3026), [#3037](max-sixty/worktrunk#3037), [#3061](max-sixty/worktrunk#3061)) - Nightly CI runs lib tests across the full feature powerset. ([#3059](max-sixty/worktrunk#3059)) - MSRV bumped from 1.94 to 1.95. ([#2948](max-sixty/worktrunk#2948)) ## Install worktrunk 0.58.0 ### Install prebuilt binaries via shell script ```sh curl --proto '=https' --tlsv1.2 -LsSf https://github.com/max-sixty/worktrunk/releases/download/v0.58.0/worktrunk-installer.sh | sh && wt config shell install ``` ### Install prebuilt binaries via powershell script ```sh powershell -ExecutionPolicy Bypass -c "irm https://github.com/max-sixty/worktrunk/releases/download/v0.58.0/worktrunk-installer.ps1 | iex"; git-wt config shell install ``` ### Install prebuilt binaries via Homebrew ```sh brew install worktrunk && wt config shell install ``` ## Download worktrunk 0.58.0 | File | Platform | Checksum | |--------|----------|----------| | [worktrunk-aarch64-apple-darwin.tar.xz](https://github.com/max-sixty/worktrunk/releases/download/v0.58.0/worktrunk-aarch64-apple-darwin.tar.xz) | Apple Silicon macOS | [checksum](https://github.com/max-sixty/worktrunk/releases/download/v0.58.0/worktrunk-aarch64-apple-darwin.tar.xz.sha256) | | [worktrunk-x86_64-apple-darwin.tar.xz](https://github.com/max-sixty/worktrunk/releases/download/v0.58.0/worktrunk-x86_64-apple-darwin.tar.xz) | Intel macOS | [checksum](https://github.com/max-sixty/worktrunk/releases/download/v0.58.0/worktrunk-x86_64-apple-darwin.tar.xz.sha256) | | [worktrunk-x86_64-pc-windows-msvc.zip](https://github.com/max-sixty/worktrunk/releases/download/v0.58.0/worktrunk-x86_64-pc-windows-msvc.zip) | x64 Windows | [checksum](https://github.com/max-sixty/worktrunk/releases/download/v0.58.0/worktrunk-x86_64-pc-windows-msvc.zip.sha256) | | [worktrunk-aarch64-unknown-linux-musl.tar.xz](https://github.com/max-sixty/worktrunk/releases/download/v0.58.0/worktrunk-aarch64-unknown-linux-musl.tar.xz) | ARM64 MUSL Linux | [checksum](https://github.com/max-sixty/worktrunk/releases/download/v0.58.0/worktrunk-aarch64-unknown-linux-musl.tar.xz.sha256) | See merge request: Harmonybrew/homebrew-core!11501
The nightly
feature-powersetjob only rancargo hack check --no-dev-deps, which never compiles#[cfg(test)]code, so test-gating breaks were invisible. Two existed on main:cargo test --lib --no-default-featuresdidn't compile (two styling tests callformat_bash_with_gutter_at_width, which is imported only undersyntax-highlighting), and once compiling, six tests failed because their assertions/snapshots bake in syntax-highlighted output.This adds
cargo hack test --feature-powerset --libas a second step on the job and gates the affected tests onsyntax-highlighting. It also gatestest_no_bold_dim_conflict, which has only negative!containsassertions and so passed vacuously without the feature. The fix to the two compile-broken styling tests is line-identical to the one onprogress-owns-counters, so the branches merge cleanly in either order. A follow-up commit builds themock-stubhelper bin before the sweep:--libis a target filter, which skips the default-members helper-bin build, so one lib test panicked on the fresh CI runner (it passed locally only because the binary already existed intarget/).The test step is bounded to
--lib: the integration suite snapshotswtoutput, which bakes in highlighted command rendering (verified: 11 snapshot failures in the first 51 tests without the feature), and ci.yaml'stestmatrix already runs it with full features on every PR.Verified locally: all 20 powerset combos pass, and the full pre-merge gate is green (3926 tests).