Repository navigation
docs(list): fix two stale comments in list collection - #3665
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly code-quality sweep: two stale doc comments in the
wt listcollection code, found while surveyingsrc/commands/list/collect/mod.rs.integration_targetscomment referenced "task spawning doesn't happen until line 1090+" — a brittle line number that is both stale and directionally impossible (the comment sits at ~L1377, and the actual spawn callswork_items_for_worktree/work_items_for_branchare at ~L1731/L1744). Replaced with a phase reference that won't rot.cache.ahead_behindentirely.)" described a refactor that has already landed: there is no longer anahead_behindfield on the in-memoryRepoCache— ahead/behind is served byRefSnapshot(src/git/repository/ref_snapshot.rs), keyed by SHA. Dropped the reference to the removed field and the completed future-step note; the remaining sentences stand on their own.Comment-only changes — no behavior change, so no regression test is applicable.