Repository navigation
Ask the harness what it holds, everywhere wt asks at all - #4054
Conversation
`wt config show` read Claude Code's `installed_plugins.json` and Gemini CLI's `~/.gemini/extensions/` directory to report the plugin and extension status. Both reads have the failure mode #4048 removed from the marketplace reader beside them: a store the tool relocated is the same missing path as one it never wrote, so an installed plugin reads as absent and the section says "Plugin not installed" over a plugin that is installed and enabled. Both answers now come from the tool: `claude plugin list --json` and `gemini extensions list -o json`, through one `harness_listing` helper the marketplace readers share. Reading another tool's file is left with a single case, and a rule rather than an exception behind it: wt reads `settings.json` because wt writes it (`install-statusline` merges the `statusLine` key in) and Claude Code has no command that reports the setting back. `claude plugin uninstall` and `claude plugin marketplace remove` both exit non-zero once their target is gone, so `wt config plugins claude uninstall` now runs both through `run_plugin_removal` — each tolerating only the absence Claude Code itself reports — instead of skipping the plugin step on a file read and exiting early with "Plugin not installed". That drops the coupled early return whose condition had to name both halves, and leaves the Claude Code and Codex uninstalls the same shape. Measured against claude 2.1.266 and codex 0.153.4: `plugin install` and `marketplace add` are idempotent, so the install's short-circuit is a convenience and an unreadable answer costs a redundant run; `plugin uninstall` is not, which is what the tolerance is for. End to end with a shim that fails only the removals, an uninstall over an installed plugin exits 1 with claude's error, and a repeat uninstall over nothing exits 0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015DzKvVGJbopPJan9YYpz4T
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015DzKvVGJbopPJan9YYpz4T
worktrunk-bot
left a comment
There was a problem hiding this comment.
wt config plugins claude uninstall's after_long_help still describes the early return this PR deletes. In src/cli/config.rs, ConfigPluginsClaudeCommand::Uninstall carries:
Requires
claudeCLI. Skips gracefully only when both are already gone. An uninstall that removed the plugin and then failed leaves the marketplace behind; running it again removes that half.
Nothing skips now — both removals run every time, and over an already-clean state the command prints Plugin & marketplace removed rather than Plugin not installed. That is the behavior change the PR body and CHANGELOG name, so the help is the one place left claiming the old contract, and it is the primary source for the command page. The Codex counterpart this PR makes the Claude uninstall match says only "Requires codex CLI."
Replacement that keeps the recovery note, which is still true:
Requires `claude` CLI. Both removals run every time, each tolerating only the "already gone" error Claude Code itself reports, so an uninstall that removed the plugin and then failed on the marketplace finishes the job when run again.
src/cli/config.rs isn't in the diff, so this is a body note rather than a suggestion; the edit also regenerates integration__integration_tests__help__help_config_plugins_claude_uninstall.snap. Happy to push it if you'd like.
…e early return `after_long_help` said the command "skips gracefully only when both are already gone" and that a half-finished uninstall leaves the marketplace for the next run to remove. Nothing skips now: both removals run every time, each tolerating only the "already gone" error Claude Code reports. The recovery half is still true and stays. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015DzKvVGJbopPJan9YYpz4T
worktrunk 0.78.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## Release Notes ### Improved - **Hook scripts read renamed context keys**: the JSON piped to every hook drops `worktree`, `repo_root`, `main_worktree`, and `main_worktree_path` in favour of `worktree_path`, `repo_path`, `repo`, and `primary_worktree_path`. Config templates migrate on load, so hooks written with the old names keep working; scripts reading the JSON, `--execute` templates, and `--var` overrides need updating. (Breaking.) ([#4080](max-sixty/worktrunk#4080)) - **`wt config plugins pi` installs for Pi; oh-my-pi moves to `wt config plugins omp`**: `pi install` wrote an oh-my-pi hook, which Pi never loads; Pi users re-run it to get a Pi extension. Existing oh-my-pi hooks keep working, listed as outdated until `wt config plugins omp install`. (Breaking: scripts that run `wt config plugins pi` for oh-my-pi need `omp`.) [Docs](https://worktrunk.dev/claude-code/#oh-my-pi) ([#4135](max-sixty/worktrunk#4135), thanks @ashebanow) - **Interactive prompts no longer open with a blank line**: `wt config shell install`, `wt config plugins claude install`, and the commit-message setup offer in `wt merge` began with one. ([#4059](max-sixty/worktrunk#4059)) - **`wt config show` gives a single `wt config shell install` hint**: an outdated wrapper, a fish wrapper at the deprecated `conf.d` path, and missing fish completions each printed their own hint. The zsh `compinit` snippet is now syntax-highlighted. ([#4059](max-sixty/worktrunk#4059)) - **`wt config update --output <path>` confirms the write**: it now prints `✓ Wrote user config migration @ ~/migrated.toml` where it printed nothing. `--output=-` stays silent. ([#4053](max-sixty/worktrunk#4053)) ### Fixed - **Removal no longer discards untracked files hidden by `status.showUntrackedFiles = no`**: under that setting, a worktree holding only untracked files looked clean, so `wt remove`, `wt merge`, and `wt step prune` removed it without `--force`. Safety checks now always count untracked files, and auto-staging warnings list every file they stage. ([#4111](max-sixty/worktrunk#4111), thanks @Duang777) - **`wt remove` and `wt merge` check the right worktree under an inherited `GIT_DIR`**: run from a `!wt` git alias or a git hook, which pass `GIT_DIR` down, `wt remove` could delete a dirty worktree without `--force`, and `wt merge` could refuse a clean merge. Both now check the worktree they act on. ([#4082](max-sixty/worktrunk#4082), thanks @Duang777) - **`wt merge` no longer deletes a worktree locked with `git worktree lock`**: the merge completes and prints `Worktree preserved (locked)`. Every Worktrunk removal refuses a locked worktree, even with `--force`; run `git worktree unlock <path>` first. ([#4073](max-sixty/worktrunk#4073), thanks @Duang777) - **`wt config update` no longer overwrites a config edited while its prompt is open**: it wrote the pre-prompt snapshot over the newer file and reported success. It now fails with the path and leaves the newer file; re-running previews the current contents. ([#4127](max-sixty/worktrunk#4127), thanks @zach-hammad-vs for reporting) - **`wt step prune` no longer deletes a branch created minutes ago from an older commit**: `--min-age` aged a branch without a worktree by its commit's date, so a new branch off a day-old commit was pruned on the next run. Age now comes from the branch's oldest reflog entry. ([#4077](max-sixty/worktrunk#4077)) - **A comment or blank line above an inline config section no longer breaks the config**: a save or migration that rewrote `commit = { … }` as `[commit]` put that line inside the brackets. `wt switch`, `wt merge`, `wt remove`, and several `wt step` commands then failed with `Failed to load config`; `wt list` warned and ran without the config. Saves also dropped unrecognized keys from inline sections. ([#4120](max-sixty/worktrunk#4120), thanks @zach-hammad-vs for reporting) - **Config saves keep the trailing comment on a value they rewrite**: a save such as answering the commit-generation offer dropped the comment after each value it rewrote, including one after an inline section's closing brace. ([#4138](max-sixty/worktrunk#4138)) - **Ignored project-config keys warn from every worktree**: an unknown key in `.config/wt.toml`, or one that belongs in user config such as `[merge]`, warned only in the main worktree, so `wt merge` from a linked worktree ignored it silently. ([#4145](max-sixty/worktrunk#4145), thanks @ee-prog for reporting) - **`wt merge` skips `post-commit` when it removes that hook's worktree**: before, the hook ran in the primary worktree when the removed one sat inside the repository, and otherwise didn't run. The merge now prints `▲ Skipped post-commit`; move work that must finish there to `pre-remove`. ([#4049](max-sixty/worktrunk#4049)) - **`wt switch` recovers from a removed worktree in a bare repository**: `wt switch` and the picker surfaced git's raw `fatal: Unable to read current working directory` instead, and the removed-directory message lacked `wt switch ^`. ([#4067](max-sixty/worktrunk#4067)) - **`wt config shell install fish` puts the wrapper where fish reads it under a custom `$XDG_CONFIG_HOME`**: the wrapper always went to `~/.config/fish/functions/`, so install reported success while `wt switch` changed no directory. On Windows, the fish completion moves from `%APPDATA%\fish\completions` to the wrapper's directory. ([#4107](max-sixty/worktrunk#4107)) - **`wt config shell install zsh` honours `$ZDOTDIR` only when it is absolute**: an empty or relative value resolved against the current directory, so install appended to a `.zshrc` under the current directory and reported success while the file zsh reads went untouched. A non-absolute value now falls back to `$HOME`. ([#4085](max-sixty/worktrunk#4085)) - **`wt config shell install` for Nushell no longer deletes a `wt.nu` under the current directory**: an empty or relative `$XDG_CONFIG_HOME` resolved against it, so install removed a `nushell/vendor/autoload/wt.nu` beneath it unread, as a stale wrapper. It now falls back to `~/.config`, which also fixes unread `tea` logins that let `wt switch pr:<n>` treat a Gitea host as GitHub. ([#4104](max-sixty/worktrunk#4104)) - **`wt switch --create` names the branch a failed worktree add leaves behind**: `git worktree add -b` writes the branch ref before populating the worktree, so a failure in between left the branch with no worktree, and the next attempt reported a name collision. The error now says how to delete or reuse it. ([#4109](max-sixty/worktrunk#4109), thanks @technicalpickles for reporting) - **`wt config shell install` no longer tells an already-wrapped shell to restart**: reinstalling from a shell with the wrapper loaded, such as after a version bump, printed `↳ Restart shell to activate shell integration`. ([#4059](max-sixty/worktrunk#4059)) - **`wt config shell install` migrates a deprecated `conf.d` fish wrapper when `~/.config/fish/functions` is missing**: before, only `wt config shell install fish` migrated it. `wt config show` now reports that wrapper even when fish isn't on `PATH`. ([#4059](max-sixty/worktrunk#4059)) - **Plugin status and uninstall checks ask the agent CLIs**: `wt config show` could list an installed Claude Code plugin or Gemini CLI extension as not installed, and `wt config plugins claude|codex uninstall` could report success over a marketplace still configured. A repeat Claude uninstall now runs both removals instead of stopping at `Plugin not installed`. ([#4048](max-sixty/worktrunk#4048), [#4054](max-sixty/worktrunk#4054)) - **`wt config plugins opencode install` no longer writes the plugin into the current directory**: with `OPENCODE_CONFIG_DIR` set but empty, it wrote `plugins/worktrunk.ts` there, typically inside a repository, reporting success though OpenCode never saw it. An empty value now counts as unset. ([#4084](max-sixty/worktrunk#4084)) - **The OpenCode plugin clears its activity marker when OpenCode 1 disposes it**: only explicit session deletion cleared it, so a finished session kept its `💬` and `wt list` showed it as active until `wt config state marker clear` was run by hand. ([#4129](max-sixty/worktrunk#4129), thanks @drewdas for reporting) - **`wt config update` migrates `[ci] platform` into a `[forge]` section that only sets `hostname`**: that config, common with GitHub Enterprise and self-hosted GitLab, kept the deprecated key with no deprecation warning. ([#4061](max-sixty/worktrunk#4061)) - **Deprecated keys in an inline `[projects]` entry now migrate**: `"example.com/org/repo" = { merge = { no-ff = true } }` skipped the migration the section form got, so the per-project setting was ignored. ([#4122](max-sixty/worktrunk#4122), thanks @zach-hammad-vs for reporting) - **A deprecated config section the migration can't rewrite now warns**: `select = "not a table"`, or a `[select]` whose `[switch.picker]` destination is already set, was ignored without a message. It now reports `unknown field select (will be ignored)`. ([#4121](max-sixty/worktrunk#4121), thanks @zach-hammad-vs for reporting) - **`wt config update` no longer changes what a template renders**: it could rename `{{ repo_root }}` inside a quoted s See merge request: Harmonybrew/homebrew-core!20435
wt config showread Claude Code'sinstalled_plugins.jsonand Gemini CLI's~/.gemini/extensions/directory to report the plugin and extension status. Both reads have the failure mode #4048 removed from the marketplace reader sitting beside them: a store the tool relocated is the same missing path as one it never wrote, so an installed plugin reads as absent and the section printsPlugin not installedover a plugin that is installed and enabled.Both answers now come from the tool —
claude plugin list --jsonandgemini extensions list -o json— through oneharness_listinghelper that the two marketplace readers share.That leaves reading another tool's file with a single case, and a rule rather than an exception behind it: wt reads
~/.claude/settings.jsonbecause wt writes it (install-statuslinemerges thestatusLinekey in) and Claude Code has no command that reports the setting back. OpenCode's and Pi's plugin files are wt's own writes too. Everything else it asks.The uninstall simplification
claude plugin uninstallandclaude plugin marketplace removeboth exit non-zero once their target is gone, sowt config plugins claude uninstallnow runs both throughrun_plugin_removal, each tolerating only the absence Claude Code itself reports. That deletes the coupled early return whose condition had to name both halves (!plugin_installed && is_marketplace_configured() == Some(false)), the conditional command preview built to match it, and two tests that had become the same run. The Claude Code and Codex uninstalls are now the same shape.Behavior change: a repeat
claude uninstallno longer printsPlugin not installedand skips. It runs both removals and reportsPlugin & marketplace removed, which is whatcodex uninstallhas always done.What was measured
Against
claude2.1.266 andcodex0.153.4, in throwawayCLAUDE_CONFIG_DIR/CODEX_HOMEdirectories:claude plugin installclaude plugin marketplace addclaude plugin uninstallclaude plugin marketplace removecodex plugin removeSo the install's short-circuit is a convenience over idempotent commands — an answer wt cannot read costs a redundant run rather than a wrong one — while the uninstall's tolerance is load-bearing.
codex plugin removekeepsrun_plugin_cli, since it has nothing to tolerate.End to end, with a shim forwarding to the real
claudeexcept forcing the removals to exit 1: an uninstall over an installed plugin exits 1 carrying claude's own error, and a repeat uninstall over nothing exits 0.wt config showreportsPlugin installed/Plugin not installedcorrectly across an install and an uninstall of the real plugin.Cost
wt config showgains one spawn per section it renders: ~140 ms forclaude, ~630 ms forgemini, taking a run with both CLIs installed from ~0.6 s to ~1.4 s. Neither query reaches the network. It is a hand-run diagnostic rather than a hot path, so the two calls stay sequential; running them concurrently would need the section renders plumbed into threads.Tests
is_plugin_installedmutated to a confidentSome(false)fails four tests, includingtest_plugins_claude_uninstall_command_fails, which is the one that would otherwise swallow a genuine failure.The harness needed one change beyond the fixtures.
configure_mock_commandsprepends mock-bin to the caller'sPATH, so a realclaudeorgeminion the developer's machine can answer in a mock's place — which is whysetup_mock_claude_installedandsetup_mock_gemini_installednow write a mock rather than only setting the detection override.Review follow-up
ConfigPluginsClaudeCommand::Uninstall'safter_long_helpstill described the early return this PR deletes ("skips gracefully only when both are already gone"). It now names the current contract, and the recovery note it carried is still true and stays:The Codex counterpart never described a skip, so it is unchanged.
claude install's "Skips gracefully if already installed" still holds.🤖 Generated with Claude Code
https://claude.ai/code/session_015DzKvVGJbopPJan9YYpz4T