Repository navigation
ci(release): publish a signed packslip with each release - #4301
Conversation
Sign a manifest of the release archives with the workflow's OIDC identity and ship it with the GitHub release, so installers can verify downloads and pick up version-matched completions and skills. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
worktrunk-bot
left a comment
There was a problem hiding this comment.
Every downstream publish job (publish-cargo, publish-winget, publish-homebrew, publish-aur) has needs: host. Because of that, a failure anywhere in this step stops gh release create and skips crates.io, winget, Homebrew and AUR for the tag. Several things can fail it: the action's gh release download / gh attestation verify of the packslip binary, the provenance attestation, a Sigstore/Rekor outage while signing, or its own packslip verify. So an outage in the newest distribution channel would hold back the release on all the established ones. The inline suggestions make the step non-blocking and copy the bundle into artifacts/ only when the step succeeded. That matters because out: artifacts combined with continue-on-error would still ship a bundle that failed its own verify step. The cost is that a release can ship without a packslip, and nothing flags it except the step's annotation. Whether that beats blocking the release is a maintainer call.
Separately, for @max-sixty: this adds a third-party composite action to the job that assembles and publishes the release. It runs with github.token (contents: write) and id-token: write, and it has read/write access to artifacts/ right before those files are attached to the release. jdx/packslip was created this month, and @v1 is a moving tag that has advanced across several releases since then. The other third-party actions in this file are also tag-pinned, so this follows existing practice. Still, this is the one step placed between the signed Windows zip and gh release create. The author offered a SHA pin, and Dependabot's github-actions entry keeps SHA pins updated. Whether to take on the dependency, and how to pin it, is your decision, so I'm leaving this as a comment rather than an approval.
Run the packslip step with continue-on-error and stage the bundle into artifacts/ only when it succeeded, so a Sigstore or packslip outage ships the release without a packslip instead of holding back every publish job, and a bundle that failed its own verify never ships. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@worktrunk-bot any downsides we should weigh? @jdx has the track record for us to adopt his early ideas |
|
No blocker from me. With the step non-blocking now, the release-path risk I raised in my review is handled. What's left to weigh:
Upside, for balance: worktrunk has no provenance attestations today, and this adds them for the five archives as a side effect. It also gives mise users version-matched completions and skills without registry drift. If you want to go ahead, I'd take the SHA pin and the step timeout. Both are small edits to this PR. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks! I took both of the bot's suggestions in 218a2cb: the action is now pinned by SHA to v1.4.0 (Dependabot will keep it current), and the step has On the signing-identity point, one update: a repository rename or transfer doesn't have to disrupt mise users. The signing certificate carries GitHub's numeric repository and owner IDs. mise keeps installing across a rename with the same repository ID, refuses a re-created repo at the old name, and asks for confirmation only on a real owner change (packslip 1.4.0 plus jdx/mise#13702, in review). Renaming For AI-assisted — Tool: Claude Code; model: anthropic/claude-opus-5-5; version: unavailable. |
Timoni and Worktrunk now publish signed packslips with their releases. `mise use timoni@0.35.0` and `mise use worktrunk@0.80.0` can install from the release manifests, verifying the workflow signature and artifact digest while also receiving the completions and version-matched skills declared by each project. The `packslip:` backend takes priority starting with Timoni 0.35.0 and Worktrunk 0.80.0. Earlier versions remain installable through their existing Aqua (and, where configured, asdf or Cargo) backends. `mise ls-remote` lists versions from the preferred backend, so older releases can be listed with `mise ls-remote aqua:stefanprodan/timoni` or `mise ls-remote aqua:max-sixty/worktrunk`. The registry declares the `timoni`, `wt`, and `git-wt` executable names so lazy install shims can select the right tool. Validated both signed releases with `mise ls-remote packslip:…` and an explicit `mise exec packslip:…@version`: `timoni --version` returned `timoni version 0.35.0`, and `wt --version` returned `wt v0.80.0`. The installed releases contain the declared executables. `mise run lint-fix` passed. Tracks #13712. Upstream release PRs: stefanprodan/timoni#659 and max-sixty/worktrunk#4301. *AI-assisted — Tool: Codex; model: OpenAI/unavailable; version: unavailable.* <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added Packslip registry support for Timoni version 0.35.0 or later and Worktrunk version 0.80.0 or later. * Registered `timoni` as a Timoni binary, and `git-wt` and `wt` as Worktrunk binaries. * Existing Aqua support for Timoni and Aqua and Cargo support for Worktrunk remain available. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This adds one step to the
hostjob inrelease.yaml. The step writes a signed packslip manifest,packslip.sigstore.json, and it ships as a release asset alongside the archives.A packslip lists each archive's digest, its platform, and where
wtandgit-wtsit inside it, plus the completions and agent skills that go with the release.What this gets you and your users
max-sixty/worktrunk's own release workflow (keyless Sigstore signing through GitHub OIDC), then checks each archive's digest and size against it before unpacking anything. mise also remembers the signer, so a release that turns up signed by a different workflow or key is not installed until the user explicitly decides to trust it. There's no signing key for you to store or rotate.wt config shell completionsfor the exact version they have installed, with nothing to add to their shell rc files.worktrunkandwt-switch-createskills ship with each release, pinned to the release commit, so an agent working with a given worktrunk release reads the skill written for that release, not whatever is on the default branch.mise skills lsshows them, andmise skills synclinks them into a project's agent directory.Once a release ships a packslip, I'll switch mise's registry entry for worktrunk to use it, so users get all of this from a plain
mise use worktrunkwith nothing to change on their end. Other installers can check the same file withpackslip verify.What it declares
worktrunk-*.tar.xz/worktrunk-*.ziparchives. It leaves out checksums, installers,source.tar.gz, andwt.rb.bin: wt git-wtwt config shell completions nuprints the full shell integration, not only completions.Release flow
Releases are immutable, and v0.79.0 is marked immutable, so the bundle can't be uploaded after
gh release create. The step therefore runs just before that command, on the final archives: after the signed Windows zip has replaced the unsigned one. It writes the bundle withupload: false, and a following step copies it intoartifacts/only if the packslip step succeeded, so the existingartifacts/*glob attaches it to the release. The packslip step hascontinue-on-error: true: a packslip or Sigstore outage ships the release without a packslip rather than holding back crates.io, winget, Homebrew and AUR, and a bundle that failed its own verification never ships.The
hostjob gainsid-token: writefor signing andattestations: write: the action attests build provenance for the five archives and links it from the manifest.hostalready runs only for tag pushes, so PR runs don't reach this step. The action is pinned by SHA to v1.4.0 (Dependabot'sgithub-actionsentry keeps it current), and the step hastimeout-minutes: 10so a stalled Sigstore call can't hold the release until the job's default timeout.Verification
packslip createwith the same artifacts, bins, and resources, signing with a throwaway local key.packslip verifythen checked all 5 of 5 artifacts and the 4 resources.worktrunk-<target>/wtandworktrunk-<target>/git-wt, orwt.exeandgit-wt.exein the zip.skills/worktrunk/SKILL.mdandskills/wt-switch-create/SKILL.mdexist at v0.79.0's commit.wtandgit-wtwithconfig shell completionsfor bash, zsh, fish, and powershell. Each printed a script that passesbash -n,zsh -n,fish --no-execute, or the PowerShell parser.actionlintreports no new findings; the 7 shellcheck infos it prints are already onmain.For maintainers
Nothing beyond merging. The first packslip appears with the next release.
I maintain packslip and mise, and I'm happy to adjust anything here. That includes dropping the
git-wtcompletions if you'd rather only registerwt.AI-assisted — Tool: Claude Code; model: anthropic/claude-opus-5-5; version: unavailable.
🤖 Generated with Claude Code