Repository navigation
Release v0.82.0 - #4716
Release v0.82.0#4716
Conversation
Keep the daemon-backed dirty check before shutdown and remove the unshipped post-stop full scan from #4456, as requested for this release. Restore cached repository configuration for macOS list pre-start. Writes during shutdown retain the v0.81 race window; the release does not adopt a full-tree rescan to close it. Temporary-index ownership and backup protection remain.
worktrunk-bot
left a comment
There was a problem hiding this comment.
Holding approval: 3075f8a loosens the dirty-worktree gate on wt remove compared with the base. stage_worktree_removal no longer runs ensure_clean_without_fsmonitor after stop_fsmonitor_daemon, so with core.fsmonitor on, a write that lands while the daemon shuts down, or a stale clean answer from the daemon, now gets renamed into trash. The new module docs say this matches git worktree remove, the PR body says the rollback was requested, and #4456 never shipped, so v0.81 users see no change. The worktrunk review rules (.claude/skills/running-tend/references/review-pr.md, "Data-Loss Surface: Hold for Human Review") still leave a change that loosens this gate for a maintainer to approve, not the bot. The rest of this push, the changelog refresh and the macOS pre-start restore, looks fine to me.
Superseded by the review on a later commit.
|
For worktrunk-bot's data-loss hold: the maintainer explicitly approved this exact rollback in the release session. The question was: “For #2, should I restore v0.81.0’s fsmonitor behavior for this release? That removes the new post-shutdown full scan and my configuration/list changes; the other release fixes remain.” Max answered: “Restore v0.81.0 behavior (Recommended)”. The preceding review explained the retained write-during-shutdown window, the daemon-backed gate, and the added full-scan cost. Commit This decision covers the fsmonitor rollback. The release still awaits the separate, full safety-review sign-off before tagging.
|
|
Thanks, that settles the hold. The maintainer decision is what my review on |
Prepares Worktrunk 0.82.0, including release notes, contributor credits, and the minor version bump required by Rust library API changes.
Protects active temporary indexes from concurrent stale-file cleanup with an owner lock, preserving forced-removal backups. Restores v0.81.0's daemon-backed removal check and cached macOS fsmonitor startup configuration, as explicitly approved by the maintainer: the unshipped post-shutdown full scan from #4456 is removed. The separate fix that spares live submodule daemons during orphan cleanup (#4729) remains.
Includes current main through
0df653384, corrected plugin documentation, and regenerated mirrors. Independent review covered the rollback, all intervening main changes, and all 30 changelog entries. Local validation passed 5,502 tests (one skipped), doctests, documentation checks, and 21 built-site tests. Full cross-platform validation and all PR checks, including patch coverage, passed.Tagging awaits explicit sign-off on the full adjudicated release safety review.