Skip to content

fix: Use patient backoff for PTY drain in progressive output tests - #57

Merged
max-sixty merged 3 commits into
mainfrom
ci
Nov 29, 2025
Merged

max-sixty merged 3 commits into
mainfrom
ci

Conversation

@max-sixty

Copy link
Copy Markdown
Owner

Summary

  • Switch from fast backoff (100ms cap) to default backoff (500ms cap, 5s timeout) for draining PTY data after child process exits
  • This prevents premature EOF detection on slow CI systems that was causing test_list_progressive_many_worktrees to fail

Test plan

  • All progressive output tests pass locally
  • Full integration test suite passes (408 tests)
  • CI passes

🤖 Generated with Claude Code

max-sixty and others added 3 commits November 28, 2025 19:50
The shell integration section is removed to simplify the documentation and streamline the user experience.
Switch from fast backoff (100ms cap) to default backoff (500ms cap, 5s
timeout) for draining PTY data after child process exits. This prevents
premature EOF detection on slow CI systems.

- Change ExponentialBackoff::fast() to default() in progressive_output.rs
- Reduce STABLE_READ_THRESHOLD from 6 to 4 (sufficient with patient backoff)
- Remove unused ExponentialBackoff::fast() method

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
The test command was exiting immediately without reading stdin, causing
a broken pipe error on stdin write before stderr could be captured. Fix
by consuming stdin first with `cat > /dev/null`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@max-sixty
max-sixty merged commit 8b0352d into main Nov 29, 2025
@max-sixty
max-sixty deleted the ci branch November 29, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant