Print warning when overwriting COPY EXTEND %{%} block from instance - #1786
Merged
Conversation
g5t
approved these changes
Dec 4, 2024
g5t
left a comment
Contributor
There was a problem hiding this comment.
This change accomplishes the goal to warn users when they overwrite an inherited component instance EXTEND block set via COPY.
I think the message could be clearer, but my opinion is not necessarily correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Candidate solution to #1785
The attached instrument
COPY_EXTEND_1has aCOMPONENT comp2=COPY(comp1)instance with anEXTEND %{%}block, which thus overwrites theEXTEND %{%}that arrives via theCOPY(comp1)clause:I further attach
COPY_EXTEND_2which has aCOMPONENT comp2=COPY(comp1)with anEXTEND %{%}block, but whereCOPY(comp1)includes noEXTENDblock: