Skip to content

Filter.comp is in fact incomplete for refraction and shape != cube. #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willend merged 2 commits into from
Jun 26, 2026
Merged

Filter.comp is in fact incomplete for refraction and shape != cube. #2522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4231515
Filter.comp is in fact incomplete for refraction and shape != cube.
willend Jun 26, 2026
9f7a0c9
Adjust %Example value, use string-var for setting mpi-friendly limits
willend Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions mcxtrace-comps/examples/SOLEIL/SOLEIL_ANATOMIX/SOLEIL_ANATOMIX.instr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
* EH3 | 165.7-174.1 | Guard slits; TXM sample stage and zone-plate table; microtomography sample stage; detector table | EH3
* EH4 | 197.2-208.5 | Guard slits; microtomography sample stage; detector table; X-ray grating interferometer | EH4
*
* %Example: -n 1e5 E0=17 Detector: psd_monitor_after_cc_I=8.7e+17
* %Example: -n 1e5 E0=17 Detector: psd_monitor_after_cc_I=1e18
*
* %Parameters
* E0: [keV] Energy selected at the Undulator.
Expand All @@ -76,6 +76,7 @@ DEFINE INSTRUMENT SOLEIL_ANATOMIX(E0=11, Emono=0, dE=1, ANGLE=0, string sample="
DECLARE
%{
double calculated_angle;
char emonopts[128];
%}

INITIALIZE
Expand All @@ -91,6 +92,7 @@ INITIALIZE
} else {
exit(printf("%s: ERROR: Monochromator energy is outside the Undulator bandwidth.\n", NAME_INSTRUMENT));
}
sprintf(emonopts,"energy limits=[%g %g], y",E0-dE,E0+dE);
%}

TRACE
Expand All @@ -110,7 +112,7 @@ COMPONENT e_repartition_before_cc = Monitor_nD(
xwidth=0.01,
yheight=0.01,
restore_xray=1,
options="auto energy, y", bins=100,
options=emonopts, bins=100,
filename="e_repartition_before_cc")
AT (0, 0, 50) RELATIVE PREVIOUS

Expand Down
10 changes: 8 additions & 2 deletions mcxtrace-comps/optics/Filter.comp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
* material_datafile: [str] File where the material parameters for the filter may be found. Format is similar to what may be found off the NIST website. [Be.txt]
* geometry: [str] File containing the polygon definition of a general shape object. When xwidth is also given, the object is rescaled accordingly (OFF/PLY)
* fixed_delta:[0/1] Use a fixed delta to compute refraction - useful for debugging.
* refraction: [0/1] If nonzero, refraction is enabled.
* refraction: [0/1] If nonzero, refraction is enabled. (Only functional for box-geometery.)
*
* %Link
* Meshlab https://www.meshlab.net/
Expand All @@ -57,7 +57,7 @@
*******************************************************************************/
DEFINE COMPONENT Filter

SETTING PARAMETERS (refraction=1,fixed_delta=0,string material_datafile="Be.txt",
SETTING PARAMETERS (refraction=0,fixed_delta=0,string material_datafile="Be.txt",
string geometry=0,xwidth=0,yheight=0,zdepth=0,radius=0)

/* X-ray parameters: (x,y,z,kx,ky,kz,phi,t,Ex,Ey,Ez,p) */
Expand Down Expand Up @@ -176,6 +176,12 @@ INITIALIZE
Table_Rebin (&(table));
printf ("done\n");
}
if (shape != CUBE) {
if (refraction) {
fprintf (stderr, "Warning(%s): refraction=1 not supported with chosen geometry\n", NAME_CURRENT_COMP);
refraction=0;
}
}
%}

TRACE
Expand Down
Loading