Support SD.Next's separate sampler for HiRes-fix. - #58
Merged
Merged
Conversation
mcmonkey4eva
reviewed
Aug 3, 2023
| if orig_sampler_name in ["DDIM", "PLMS"]: | ||
| raise RuntimeError(f"Cannot use sampler {orig_sampler_name} with Dynamic Thresholding") | ||
| if orig_sampler_name == 'UniPC' and p.enable_hr: | ||
| if orig_latent_sampler_name in ["DDIM", "PLMS"]: |
Member
There was a problem hiding this comment.
This... just ignores the original sampler?
Contributor
Author
There was a problem hiding this comment.
Can you please rephrase that? I'm not sure I understand what is the issue here.
The check at lines 94-95 is supposed to disallow DDIM and PLMS for hires-fix sampler, just like it does for original sampler.
The check for UniPC is at line 96.
Member
There was a problem hiding this comment.
Oh, wait, my bad, I misread, sorry.
Member
|
Seems to work fine indeed on auto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently SD.Next started to use
params.latent_samplerfor hires-fix pass, which can differ from main sampler. This change incidentally completely broke Dynamic Thresholding when doing hires-fix pass.I did not test this PR with the original AUTOMATIC1111's webui version, but it should (probably) work just fine.