Update bank_example.py - #2
Open
malusdei wants to merge 3 commits into
Open
Conversation
The .read and .execute_sql functions of the Database() library were deprecated in a commit. Added an new (commented out) snippet to propose reading through a snapshot, rather than the Database() object. However, Snapshot object is still buggy too. (See https://b.corp.google.com/issues/67737332 )
All database.execute_sql() reads have been replaced with snapshot reads instead. Tested and confirmed on a Python 2.7 environment. Unfortunately, tested and confirmed it is failing on a Python 3.6 environment. There is a ticket open for this. All code example now work on Python v2.7 as of this writing.
Replaced database.execute_sql reads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .read and .execute_sql functions of the Database() library were deprecated in a commit. Added an new (commented out) snippet to propose reading through a snapshot, rather than the Database() object. However, Snapshot object is still buggy too. (See https://b.corp.google.com/issues/67737332 )