add 202605 - #3
Merged
Merged
Conversation
Tomohiro-Iwasaki
requested review from
90283okadachihei,
kymn2024 and
nishikori-t
August 4, 2026 06:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Google Ad Manager API v202505 が sunset され、embulk-admanager から BigQuery への同期が失敗するようになりました。
現行の最新である v202605 を追加します。前回の #2 (add 202505) と同じ方針です。
変更内容
ad_manager_api/lib/ad_manager_api/v202605/を追加(86ファイル)。公式リポジトリの v202605 をそのままコピー(自動生成コードのため改変なし)api_config.rb:DEFAULT_VERSION/LATEST_VERSIONを:v202605に更新、@@service_configに:v202605(43サービス)を追加、@@configにエンドポイントを追加既存の v202308〜v202505 の定義はロールバック用にすべて残しています。gemspec(
required_ruby_version >= 2.3/google-ads-common ~> 2.0)は変更していません。Embulk 0.9 系同梱の JRuby が Ruby 2.3 互換であり、公式 gem の>= 3.1ではembulk bundle installが失敗するためです。検証
api_config.rbと v202605 の全86ファイルでruby -c→ 構文OKDATE,CUSTOM_CRITERIA,AD_SERVER_IMPRESSIONS等)とCSV_DUMPが v202605 のレジストリに存在関連作業
マージ後、embulk-admanager 側で
API_VERSIONを:v202605に変更し、コンテナイメージの再ビルドが必要です。🤖 Generated with Claude Code