coroutine make_request was never awaited during sl pr pull #583

Activity

1. zzl0 commented on Mar 25, 2023

   

   zzl0

   on Mar 25, 2023

   Last edited by zzl0

   Contributor

   More actions

   Hi @zsol, thanks for posting the issue and steps to reproduce it. Yes, the issue here is the nested async event loops, this was due to a recent change of moving pr_marker inline instead of as a separate hook.

   We probably can solve it by using nest_asyncio, but I will check if we can eliminate the nested event loop next week. For now, you can add below config to your config file by running sl config -e to disable pr_marker, and run sl debugprmarker manually if you want to hide landed PRs.

    [github]
    hide-landed-commits=False
   

   Below is the trace stack (simplified) of the nested event loop:

   import_pull_request.get_pr(ui, repo, *args, **opts)
   ...
   return asyncio.run(_get_pr(ui, repo, pr_id=pr_id, is_goto=is_goto)) # <-- First event loop
   ...
   git.pull(self, source, names=bookmarknames, nodes=headnodes)
   ...
   _pull(orig, repo, source, names=(), nodes=())
   ...
   pr_marker.cleanup_landed_pr(repo)
   ...
   response = github.graphql_sync(query, owner=pr.owner, name=pr.name, number=pr.number) # <-- Second event loop
   

   👍React with 👍1Reacted by Zsolt Dollenstein
2. zzl0

   self-assigned this

   on Mar 25, 2023
3. zzl0

   added

   bug

   pr

   fix readyA fix was created. It's pending review or push.A fix was created. It's pending review or push.

   on Mar 25, 2023
4. zzl0 commented on Apr 3, 2023

   

   zzl0

   on Apr 3, 2023

   Contributor

   More actions

   Fixed in 3f6cd0c

   Madepr_marker run as a post-pull hook instead of running it as part of the pull function (via a high-order wrapper function).
5. zzl0

   closed this as completedon Apr 3, 2023