Repository navigation
[eslint-plugin] allow local resolved constants in valid-styles number checks - #1216
Merged
Merged
Conversation
mellyeliu
force-pushed
the
eslint-fix
branch
from
September 3, 2025 17:39
1f0b83e to
359ec43
Compare
workflow: benchmarks/perfComparison of performance test results, measured in operations per second. Larger is better.
|
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
mellyeliu
marked this pull request as ready for review
September 3, 2025 17:45
mellyeliu
requested review from
Jta26,
ezzak,
necolas and
vincentriemer
as code owners
September 3, 2025 17:45
vincentriemer
approved these changes
Sep 3, 2025
2 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
isNumberlint check was incorrectly flagging identifiers for constants declared in the same file. We generally allow them in place of number literals as Babel handles the static evaluation of these bindings.The rule now resolves scope correctly so that same-file
constidentifiers initialized with numbers can be used within arithmetic expressions and pass without error.Within the
isNumbercheckgetScopeto determine whether any identifiers are declared within the file