Repository navigation
[eslint-plugin] Allow stylex token arguments in firstThatWorks - #1996
Open
henryqdineen wants to merge 1 commit into
Open
henryqdineen wants to merge 1 commit into
henryqdineen wants to merge 1 commit into
Conversation
Validating each firstThatWorks argument bypassed the existing exemption for imported .stylex token references, which only applied to the whole property value. Common patterns like `firstThatWorks(tokens.button.opacity, '1')` started failing valid-styles. Skip recognized token arguments and keep validating the rest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
meta-cla
Bot
added
the
CLA Signed
henryqdineen
changed the title
henryqdineen
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
#1620 validates each
firstThatWorksargument, but the existing exemption for imported.stylextokens only applied to the whole property value. Soopacity: stylex.firstThatWorks(tokens.button.opacity, '1')started failingvalid-styles.This skips token arguments inside
firstThatWorksusing the existingisStylexResolvedVarsTokenhelper. All other arguments are still validated.Linked PR/Issues
Follow-up to #1620
Additional Context
Tests added:
Pre-flight checklist
🤖 Generated with Claude Code