Skip to content

[babel-plugin] Fix paddingInline not resetting paddingInlineStart/End in application-order #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henryqdineen wants to merge 2 commits into
base: main
Choose a base branch
from
+92 −8
Open

[babel-plugin] Fix paddingInline not resetting paddingInlineStart/End in application-order #2020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84a95e4
[babel-plugin] Fix paddingInline not resetting logical inline longhands
henryqdineen Nov 8, 2026
ded9263
Merge branch 'main' into hqd-fix-padding-inline-application-order
henryqdineen Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 90 additions & 6 deletions packages/@stylexjs/babel-plugin/__tests__/legacy/stylex-transform-call-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,9 +369,9 @@ describe('@stylexjs/babel-plugin', () => {
foo: {
kmVPX3: "x14odnwx",
kg3NbH: null,
kuDDbn: null,
kZCmMZ: null,
kE3dHu: null,
kP0aTx: null,
kwRFfy: null,
kpe85a: null,
k8WAf4: null,
kLKAdn: null,
Expand Down Expand Up @@ -475,9 +475,9 @@ describe('@stylexjs/babel-plugin', () => {
foo: {
kmVPX3: "x14odnwx",
kg3NbH: null,
kuDDbn: null,
kZCmMZ: null,
kE3dHu: null,
kP0aTx: null,
kwRFfy: null,
kpe85a: null,
k8WAf4: null,
kLKAdn: null,
Expand Down Expand Up @@ -982,7 +982,7 @@ describe('@stylexjs/babel-plugin', () => {
ltr: ".xe2zdcy{padding-inline-start:10px}",
priority: 3000
});
"x2vl965 x1i3ajwb xe2zdcy";"
"x1i3ajwb xe2zdcy";"
`);
});

Expand Down Expand Up @@ -1019,7 +1019,91 @@ describe('@stylexjs/babel-plugin', () => {
ltr: ".x1i3ajwb{padding:2px}",
priority: 1000
});
"x2vl965 x1i3ajwb";"
"x1i3ajwb";"
`);
});

test('stylex call with padding shorthands after logical inline longhands', () => {
expect(
transform(`
import stylex from 'stylex';
const styles = stylex.create({
start: { paddingInlineStart: 10 },
end: { paddingInlineEnd: 10 },
padding: { padding: 0 },
paddingInline: { paddingInline: 0 },
});
stylex(styles.start, styles.padding);
stylex(styles.end, styles.padding);
stylex(styles.start, styles.paddingInline);
stylex(styles.end, styles.paddingInline);
`),
).toMatchInlineSnapshot(`
"import _inject from "@stylexjs/stylex/lib/stylex-inject";
var _inject2 = _inject;
import stylex from 'stylex';
_inject2({
ltr: ".xe2zdcy{padding-inline-start:10px}",
priority: 3000
});
_inject2({
ltr: ".x2vl965{padding-inline-end:10px}",
priority: 3000
});
_inject2({
ltr: ".x1717udv{padding:0}",
priority: 1000
});
_inject2({
ltr: ".xnjsko4{padding-inline:0}",
priority: 2000
});
"x1717udv";
"x1717udv";
"xnjsko4";
"xnjsko4";"
`);
});

test('stylex call with margin shorthands after logical inline longhands', () => {
expect(
transform(`
import stylex from 'stylex';
const styles = stylex.create({
start: { marginInlineStart: 10 },
end: { marginInlineEnd: 10 },
margin: { margin: 0 },
marginInline: { marginInline: 0 },
});
stylex(styles.start, styles.margin);
stylex(styles.end, styles.margin);
stylex(styles.start, styles.marginInline);
stylex(styles.end, styles.marginInline);
`),
).toMatchInlineSnapshot(`
"import _inject from "@stylexjs/stylex/lib/stylex-inject";
var _inject2 = _inject;
import stylex from 'stylex';
_inject2({
ltr: ".x1hm9lzh{margin-inline-start:10px}",
priority: 3000
});
_inject2({
ltr: ".x1sa5p1d{margin-inline-end:10px}",
priority: 3000
});
_inject2({
ltr: ".x1ghz6dp{margin:0}",
priority: 1000
});
_inject2({
ltr: ".xrxpjvj{margin-inline:0}",
priority: 2000
});
"x1ghz6dp";
"x1ghz6dp";
"xrxpjvj";
"xrxpjvj";"
`);
});

Expand Down
4 changes: 2 additions & 2 deletions packages/@stylexjs/babel-plugin/src/shared/preprocess-rules/application-order.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,9 +626,9 @@ const shorthands: $ReadOnly<{ [key: string]: (TStyleValue) => TReturn }> = {
},
paddingInline: (rawValue: TStyleValue): TReturn => [
['paddingInline', rawValue],
['paddingStart', null],
['paddingInlineStart', null],
['paddingLeft', null],
['paddingEnd', null],
['paddingInlineEnd', null],
['paddingRight', null],
],
paddingBlock: (rawValue: TStyleValue): TReturn => [
Expand Down
Loading