Skip to content

fix: Add more unitless properties - #705

Merged
nmn merged 2 commits into
mainfrom
fix/unitless-grid-props
Oct 1, 2024
Merged

nmn merged 2 commits into
mainfrom
fix/unitless-grid-props

Conversation

@nmn

@nmn nmn commented Oct 1, 2024

Copy link
Copy Markdown
Collaborator

Don't add px to numbers used for grid properties.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 1, 2024
@github-actions

github-actions Bot commented Oct 1, 2024 •

Copy link
Copy Markdown

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/scripts@0.7.5 size:compare
./size-compare.js /tmp/tmp.twg5qROu3P /tmp/tmp.e37bbTkxf4

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 899 899 1.00
· minified 3,223 3,223 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 563,484 563,563 1.00 +
· minified 10,185,368 10,185,348 1.00 -
rollup-example/.build/stylex.css
· compressed 99,154 100,211 1.01 +
· minified 745,649 759,868 1.02 +

This branch was successfully deployed

1 active deployment
Preview — c824af99 Deployed Oct 1, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants