Repository navigation
Conversation
After a finished frame, ZSTD_decompressContinue() accepted srcSize == 0 and read 4 bytes from src, crashing when src is NULL. A new DCtx left the decoder state uninitialized. Both cases now return stage_wrong.
terrelln
approved these changes
Nov 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZSTD_decompressContinue()requiresZSTD_decompressBegin()before each frame, as documented in #4933, but nothing enforced it.After a finished frame,
ZSTD_decompressContinue(dctx, dst, cap, src, 0)passed the size check and read 4 bytes fromsrc: a heap overflow under ASan, a segfault whensrcisNULL.On a new
DCtx,stageandexpectedwere not initialized at all.ZSTD_initDCtx_internal()now initializes them, andZSTD_decompressContinue()returnsstage_wrongin both cases.