[lenny] integrate upstream block/main bfc3848558 (8 commits)

.github/workflows/_ci-clients.yml

@@ -82,7 +82,10 @@ jobs:
           key: ${{ runner.os }}-hermit-cache-${{ steps.hermit-bin-hash.outputs.hash }}
           restore-keys: ${{ runner.os }}-hermit-cache-
       - name: Prime Flutter SDK
-        run: flutter --version
+        run: |
+          flutter --version
+          flutter --version --machine > "$RUNNER_TEMP/mobile-flutter-version.json"
+          printf '%s\n' "$GITHUB_SHA" > "$RUNNER_TEMP/mobile-tested-sha.txt"
       - name: Save Hermit package cache
         if: always() && steps.hermit-cache.outputs.cache-hit != 'true'
         uses: actions/cache/save@caa296126883cff596d87d8935842f9db880ef25 # v5
@@ -112,6 +115,17 @@ jobs:
         run: cd mobile && flutter analyze
       - name: Test
         run: cd mobile && flutter test
+      - name: Upload mobile failure evidence
+        if: ${{ failure() }}
+        uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
+        with:
+          name: mobile-failures-${{ github.run_id }}-${{ github.run_attempt }}
+          path: |
+            mobile/test/**/failures/*.png
+            ${{ runner.temp }}/mobile-flutter-version.json
+            ${{ runner.temp }}/mobile-tested-sha.txt
+          if-no-files-found: error
+          retention-days: 7
       - name: Build Android debug APK
         run: just mobile-build-android
 

desktop/tests/e2e/thread-reply-anchor-roleplay.spec.ts

@@ -202,8 +202,12 @@ test.describe("thread reply anchor A/B roleplay screenshots", () => {
 
     await openThread(page);
     await expandReply(page, humanReply.id);
-    await expect(page.getByText("Nora: adding context")).toBeVisible();
-    await expect(page.getByText("Pinky: Got it")).toBeVisible();
+    // Scope to the thread panel: the timeline's sr-only aria-live region
+    // (message-timeline-announcements) echoes message text and otherwise
+    // makes these text locators resolve to 2 elements (strict mode).
+    const threadPanel = page.getByTestId("message-thread-panel");
+    await expect(threadPanel.getByText("Nora: adding context")).toBeVisible();
+    await expect(threadPanel.getByText("Pinky: Got it")).toBeVisible();
     await expect(
       page.getByTestId("message-thread-replies").getByTestId("message-row"),
     ).toHaveCount(2);
@@ -253,8 +257,10 @@ test.describe("thread reply anchor A/B roleplay screenshots", () => {
     );
 
     await openThread(page);
-    await expect(page.getByText("Nora: adding context")).toBeVisible();
-    await expect(page.getByText("Pinky: Got it")).toBeVisible();
+    // Scoped to the thread panel — see test 01 for the aria-live note.
+    const threadPanel = page.getByTestId("message-thread-panel");
+    await expect(threadPanel.getByText("Nora: adding context")).toBeVisible();
+    await expect(threadPanel.getByText("Pinky: Got it")).toBeVisible();
     await expect(
       page.getByTestId("message-thread-replies").getByTestId("message-row"),
     ).toHaveCount(2);
@@ -292,7 +298,11 @@ test.describe("thread reply anchor A/B roleplay screenshots", () => {
     );
 
     await openThread(page);
-    await expect(page.getByText("Pinky: Starting the audit")).toBeVisible();
+    // Scoped to the thread panel — see test 01 for the aria-live note.
+    const threadPanel = page.getByTestId("message-thread-panel");
+    await expect(
+      threadPanel.getByText("Pinky: Starting the audit"),
+    ).toBeVisible();
     await expect(
       page.getByTestId("message-thread-replies").getByTestId("message-row"),
     ).toHaveCount(1);
@@ -339,8 +349,12 @@ test.describe("thread reply anchor A/B roleplay screenshots", () => {
 
     await openThread(page);
     await expandReply(page, brainReply.id);
-    await expect(page.getByText("Brain: Check the anchor")).toBeVisible();
-    await expect(page.getByText("Pinky: Good catch")).toBeVisible();
+    // Scoped to the thread panel — see test 01 for the aria-live note.
+    const threadPanel = page.getByTestId("message-thread-panel");
+    await expect(
+      threadPanel.getByText("Brain: Check the anchor"),
+    ).toBeVisible();
+    await expect(threadPanel.getByText("Pinky: Good catch")).toBeVisible();
     await expect(
       page.getByTestId("message-thread-replies").getByTestId("message-row"),
     ).toHaveCount(2);

desktop/tests/e2e/thread-unread.spec.ts

@@ -986,7 +986,10 @@ test.describe("thread unread indicator", () => {
     const openMenu = async () => {
       await expect(toggle).toHaveCount(0);
       await page.mouse.move(0, 0);
-      await page.getByText("Toggle me").hover();
+      // Scope the hover to the timeline: the sr-only aria-live region
+      // (message-timeline-announcements) echoes message text and would
+      // otherwise make this locator resolve to 2 elements (strict mode).
+      await page.getByTestId("message-timeline").getByText("Toggle me").hover();
       await moreActions.click();
       await expect(toggle).toHaveCount(1);
     };

mobile/test/features/channels/thread_detail_page/task_detail_sheet_test.dart

@@ -239,11 +239,11 @@ void main() {
       expect(find.textContaining('To do'), findsOneWidget);
       // 'In progress' appears in the header status and the transition row.
       expect(find.textContaining('In progress'), findsWidgets);
-      // Actor pubkeys render truncated, plain text.
+      // Actor pubkeys render as the canonical compact npub label, plain text.
       final actorText = tester.widget<Text>(
         find.byKey(const ValueKey('task-event-actor-1')),
       );
-      expect(actorText.data, '${'a' * 8}\u2026');
+      expect(actorText.data, 'npub1424…rcaj');
     });
 
     testWidgets('omits the summary section entirely when absent', (

mobile/test/features/channels/thread_summarize_action_test.dart

@@ -29,19 +29,15 @@ void main() {
         },
       );
 
-      expect(digest.map((entry) => entry.author), ['Ada', 'def456']);
+      expect(digest.map((entry) => entry.author), ['Ada', 'Unknown identity']);
       expect(digest.map((entry) => entry.text), ['first', 'second']);
     });
 
     test('shortens a long pubkey when no profile is cached', () {
       final digest = threadSummaryDigest([
-        _message(
-          id: '1',
-          pubkey: 'aaaaaaaabbbbbbbbccccccccdddddddd',
-          content: 'hello',
-        ),
+        _message(id: '1', pubkey: 'b' * 64, content: 'hello'),
       ], profiles: const {});
-      expect(digest.single.author, 'aaaaaaaa…');
+      expect(digest.single.author, 'npub1hwa…04hu');
     });
 
     test('drops system rows, which are chrome rather than conversation', () {