Repository navigation
[Fusion] Cover name lookups on composite result objects with partial selection sets - #145
Merged
michaelstaib merged 2 commits intoNov 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for name lookups on composite result objects whose selection set is only partly present, because
@skip/@includeexcluded fields or@deferdeferred them. Tests coverTryGetPropertyand the other name lookups onCompositeResultDocument.The tests show the lookups already return the right property, or none, in each case. No product code changed.
Tests:
CompositeResultDocumentTestscompiles operations with conditional and deferred selections and looks up every field by name, including a name that is not in the selection set.DeferTestsadds gateway tests for a deferred group with a skipped field and for nested@defer. The merged deferred result is checked against the non-deferred result.One thing the snapshot shows but this PR does not change: when the only field of an outer deferred group is skipped, the gateway still sends an incremental entry with empty data.
Test-only change, no benchmark run.