Repository navigation
Cover the group slots of execution group members dropped by a non-null violation - #183
Open
michaelstaib wants to merge 1 commit into
Open
michaelstaib wants to merge 1 commit into
michaelstaib wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for this test-only change adding regression coverage for dropped execution-group members and task cleanup.
No open issues 🎉
What changed in this PR
Adds regression tests for execution-group members dropped by non-null violations, extending the child-task cleanup coverage from #138. No product code changes.
Changes:
- Verifies that a later group member still runs when an earlier member is dropped.
- Verifies request completion when a non-null group root is nulled after member tasks are created.
- Counts resolver-task rentals and returns to check that all tasks return to the pool.
| File | Description |
|---|---|
src/HotChocolate/Core/test/Execution.Tests/ExecutionGroups/ExecutionGroupDroppedMemberTests.cs |
Adds two dropped-member regression tests and a counting resolver-task pool. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for execution group members dropped by a non-null violation. A dropped member is never registered, and the task that drops it releases the member's group slot when its turn ends, so later members still run.
Changes:
ExecutionGroupDroppedMemberTestscount the resolver tasks returned to the pool:No product code changes.
Stacked on #138.
Tests: the first test hangs if the slot release for unregistered children is removed. Execution.Tests pass on net10.0 and net8.0.