Skip to content

fix: fix incorrect replacement of Object properties - #145

Closed
tmair wants to merge 1 commit into
micromatch:masterfrom
tmair:fix-incorrect-replacement
Closed

tmair wants to merge 1 commit into
micromatch:masterfrom
tmair:fix-incorrect-replacement

Conversation

@tmair

@tmair tmair commented Jun 17, 2025

Copy link
Copy Markdown

When creating a RegExp via makeRe for one of the default properties of Object (constructor is one of them), the creation fails, because the replacement is applied.

This PR fixes the issue by creating the replacement object without a prototype and adds a test to verify that it works correctly.

@tmair

tmair commented Jun 17, 2025

Copy link
Copy Markdown
Author

Ok, this seems to be address by two PRs already
#144
#132

@danez

danez commented Mar 19, 2026

Copy link
Copy Markdown
Member

Fixed by #144

@danez danez closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants