Fix extension chart for FF & MC - #1765
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. |
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. |
suyadav1
enabled auto-merge (squash)
August 18, 2026 21:17
rashmichandrashekar (rashmichandrashekar)
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way cloud environment selection is handled for domain configuration in the Azure Monitor Container Insights Helm chart. Instead of using boolean flags for specific environments, it now uses a single variable to determine the cloud environment, simplifying configuration and reducing potential errors.
Cloud environment configuration improvements:
isMoonCakeandisFairfaxboolean flags invalues-template.yamlwith a single$cloudEnvvariable to determine the cloud environment.ama-logs-secret.yamlto use$cloudEnvfor selecting the correct domain for China (azurechinacloud) and US Government (azureusgovernmentcloud) environments, instead of the removed boolean flags.