Skip to content

Trace Parser: clarify required SQL setup and fix DeleteTrace procedure mapping - #567

Open
Martin Valov (marval) wants to merge 1 commit into
microsoft:masterfrom
marval:fix/traceparser-readme-and-deletetrace
Open

Martin Valov (marval) wants to merge 1 commit into
microsoft:masterfrom
marval:fix/traceparser-readme-and-deletetrace

Conversation

@marval

Copy link
Copy Markdown

Summary

  • Document that SQL setup is required before starting DAB:
    • Run Create Views.sql
    • Run Create Keyword Search SPs.sql
  • Add local and Azure setup guidance so required views and stored procedures are created in the target database.
  • Fix DeleteTrace stored procedure mapping in dab-config.json from dbo.sp_DeleteTrace to dbo.DeleteTrace.
  • Clarify exposed behavior so documentation aligns with available execute endpoints.

Stack and review scope

  • Base branch: master
  • Scope is intentionally small:
    • Documentation updates for setup and behavior clarity
    • Single configuration correction for DeleteTrace mapping
  • No schema changes are introduced by this PR itself; it only aligns docs and config with existing SQL object expectations.

Validation

  • Verified diff is limited to README.md and dab-config.json.
  • Confirmed mapping update is consistent with expected SQL object name dbo.DeleteTrace.
  • Confirmed setup instructions now explicitly call out manual execution of SQL scripts that provide required views and stored procedures.

Compatibility and exclusions

  • No changes to authentication, hosting topology, deployment scripts, or infrastructure resources.
  • No data migration or backfill is included.
  • No application runtime logic changes beyond correcting the stored procedure target name in config.
  • This PR does not perform or trigger deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant