Enable applications to report what features are being used, what were the states during a request, etc... #3

Activity

1. kevinv53 commented on May 7, 2023

   

   kevinv53

   on May 7, 2023

   Last edited by kevinv53

   More actions

   Is there any update on this?

   There is Azure Monitoring and Cost Analysis but I'm not sure that those cover what is requested on this ticket.
2. jimmyca15 commented on May 8, 2023

   

   Jimmy Campbell (jimmyca15)

   on May 8, 2023

   MemberAuthor

   More actions

   Hello kevinv53 this is the issue that we are currently designing a solution for. The current line of thought is to have an interface that is internally invoked whenever a flag is evaluated.

   Exact interface and naming TBD, but something along the lines of the following:

   ITelemetryPublisher
   {
       ValueTask Publish(EvaluationResult result, CancellationToken cancellationToken);
   }
   
   public class EvaluationResult
   {
       string FeatureName { get; set; }
   
       bool Enabled { get; set; }
   }
   

   It allows one to implement ITelemetryPublisher and emit/persist feature flag evaluations wherever desired.

   👍React with 👍1Reacted by Ross Grambo
3. Jimmy Campbell (jimmyca15)

   assigned

   Ross Grambo (rossgrambo)

   on Sep 28, 2023
4. jimmyca15 commented on Oct 13, 2023

   

   Jimmy Campbell (jimmyca15)

   on Oct 13, 2023

   MemberAuthor

   More actions

   Added in preview branch

   #259

   #281
5. amis92 commented on Oct 25, 2023

   

   Amadeusz Sadowski (amis92)

   on Oct 25, 2023

   Last edited by amis92

   More actions

   I am excited for the work done in this area, however seeing the ITelemetryPublisher I couldn't help but wonder, why was DiagnosticSource not used? It seems like a perfect fit for this purpose. I'd even consider ActivitySource usage since some feature evaluations can be complex and even hit external dependencies, and having distributed tracing support for such cases could be very helpful. And these are native, runtime built-in solutions for exactly that purpose. ApplicationInsights integration with DiagnosticSource would be a breeze (it's how appins creates RequestTelemetry), and it'd also make it easy to integrate with any and all other OTel-based components nearly out of the box.

   I think this was essentially what was asked for in #219

   Would you still consider working in that direction, or is ITelemetryPublisher definitely your last word in this area?

   👍React with 👍1Reacted by James Thompson
6. jimmyca15 commented on Oct 25, 2023

   

   Jimmy Campbell (jimmyca15)

   on Oct 25, 2023

   MemberAuthor

   More actions

   Amadeusz Sadowski (@amis92)

   Can't an implementation of ITelemetryPublisher be made to satsify what you have suggested?
7. amis92 commented on Oct 25, 2023

   

   Amadeusz Sadowski (amis92)

   on Oct 25, 2023

   More actions

   It can, but that doesn't make a lot of sense to me - as I see it, the TelemetryPublisher is a custom solution duplicating existing framework component. I don't see what's the benefit doing it this way instead of framework-standard. As a bonus, there'd be less public API surface, less maintenance, and more possible optimizations from using framework code.
8. jimmyca15 commented on Oct 27, 2023

   

   Jimmy Campbell (jimmyca15)

   on Oct 27, 2023

   MemberAuthor

   More actions

   Amadeusz Sadowski (@amis92)

   From my understanding DiagnosticSource doesn't play as well as we'd like with DI to put us where we want to be for this enhancement. I'm not aware of any patterns to have diagnostic source listeners be DI aware. This makes it a bit difficult to work with in our case given the libraries focus on DI usage.

   See current proposed usage in Application Insights publisher example:

   builder.Services.AddFeatureManagement()
       .AddTelemetryPublisher<ApplicationInsightsTelemetryPublisher>();
   

   I appreciate any thoughts you have on the topic.
9. amis92 commented on Nov 30, 2023

   

   Amadeusz Sadowski (amis92)

   on Nov 30, 2023

   More actions

   It seems there's now IMeterFactory which satisfies the Dependency Injection scenario :) https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.metrics.imeterfactory?view=net-8.0

   It'd be helpful if the framework-based solutions could work more-or-less out of the box, instead of depending on an Azure-focused extension.

   👍React with 👍1Reacted by Zhiyuan Liang