Skip to content

add runtests - #473

Merged
David Federman (dfederm) merged 30 commits into
microsoft:mainfrom
novacole:dev/colecarter/runtests
Feb 9, 2024
Merged

David Federman (dfederm) merged 30 commits into
microsoft:mainfrom
novacole:dev/colecarter/runtests

Conversation

@novacole

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/RunTests/build/Microsoft.Build.RunTests.targets Outdated
Comment thread src/RunTests/RunTestsTask.cs Outdated
Comment thread src/RunTests/Microsoft.Build.RunTests.csproj Outdated
Comment thread src/RunTests/README.md Outdated
@MarcoRossignoli

Marco Rossignoli (MarcoRossignoli) commented Sep 1, 2023 •

Copy link
Copy Markdown

cc: Jakub Jareš (@nohwnd) Amaury Levé (@Evangelink) for review

Comment thread src/RunTests/build/Microsoft.Build.RunTests.props Outdated
Comment thread src/RunTests/build/Microsoft.Build.RunTests.targets Outdated
Comment thread src/RunTests/README.md Outdated
Comment thread src/RunTests/build/Microsoft.Build.RunTests.targets Outdated
Comment thread src/RunTests/README.md Outdated
Comment thread src/RunTests/build/Microsoft.Build.RunVSTest.targets Outdated
Comment thread Directory.Packages.props Outdated
Comment thread src/RunTests/README.md
Comment thread src/RunTests/README.md Outdated
Comment thread src/RunTests/Microsoft.Build.RunVSTest.csproj Outdated
Comment thread src/RunTests/build/Microsoft.Build.RunVSTest.props Outdated
Comment thread src/RunTests/build/Microsoft.Build.RunVSTest.props Outdated
Comment thread src/RunTests/RunVSTestTask.cs Outdated
Comment thread src/RunTests/RunVSTestTask.cs Outdated
Comment thread src/RunTests/RunVSTestTask.cs Outdated
Comment thread src/RunTests/RunVSTestTask.cs Outdated
Comment thread src/RunTests/RunVSTestTask.cs Outdated
Comment thread src/RunTests/README.md
Comment thread src/RunTests/README.md Outdated
Comment thread src/RunTests/README.md Outdated
Comment thread src/RunTests/RunVSTestTask.cs Outdated
Comment thread src/RunTests/build/Microsoft.Build.RunVSTest.props Outdated
Comment thread src/RunTests/RunVSTestTask.cs Outdated
@novacole
Cole Carter (novacole) marked this pull request as ready for review February 9, 2024 00:33
@nohwnd

Copy link
Copy Markdown
Member

I have been doing quite a lot of changes to vstest targets and tasks, I would love this to take dependency on stable version of https://www.nuget.org/packages/Microsoft.TestPlatform.Build which ships them.

@novacole

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@novacole

Cole Carter (novacole) commented Feb 9, 2024 •

Copy link
Copy Markdown
Contributor Author

I have been doing quite a lot of changes to vstest targets and tasks, I would love this to take dependency on stable version of https://www.nuget.org/packages/Microsoft.TestPlatform.Build which ships them.

This no longer has a direct dependency on Microsoft.TestPlatform, it instead uses the vstest.console.exe shipped with VS for the MSBuild case, and for the dotnet case, it uses the one shipped with the dotnet sdk. Jakub Jareš (@nohwnd)

@dfederm
David Federman (dfederm) merged commit b207ebd into microsoft:main Feb 9, 2024
@nohwnd

Copy link
Copy Markdown
Member

Microsoft.TestPlatform**.Build** contains the msbuild task and target that we use to invoke vstest.console, depending I think that depending on it could avoid duplicating the task and target in this sdk, e.g. src/RunTests/RunVSTestTask.cs, we also have a new task and target that integrates better with msbuild and terminal logger that we are actively developing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants