Repository navigation
FIX: Detect pseudo-protocol redirects in OpenRedirectOutputScorer (#4235) - #4236
Open
Vardhman Gupta (Kaap10) wants to merge 2 commits into
Open
Vardhman Gupta (Kaap10) wants to merge 2 commits into
Vardhman Gupta (Kaap10) wants to merge 2 commits into
Conversation
| _EXECUTABLE_DATA_MIME_TYPES = ( | ||
| rf"(?:text{_SLASH}(?:html|(?:x-)?javascript|ecmascript)" | ||
| rf"|image{_SLASH}svg{_PLUS}xml" | ||
| rf"|application{_SLASH}(?:x-)?javascript)(?![A-Za-z0-9+_-])" |
Contributor
There was a problem hiding this comment.
data:application/xhtml+xml slips past this list, browsers run script in xhtml data URIs same as text/html, so url=data:application/xhtml+xml,<html xmlns="http://www.w3.org/1999/xhtml"><script>alert(1)</script></html> still scores false
Suggested change
| rf"|application{_SLASH}(?:x-)?javascript)(?![A-Za-z0-9+_-])" | |
| rf"|application{_SLASH}(?:(?:x-)?javascript|xhtml{_PLUS}xml))(?![A-Za-z0-9+_-])" |
fixed this plus a test in this commit, you can just cherry pick it instead of redoing it: its-amann@caaaf07
Contributor
Author
There was a problem hiding this comment.
Good catch! Modern browsers do parse and execute scripts inside application/xhtml+xml data URIs. Added detection along with positive and negative lookahead test cases in 7a6d08f. Thanks for the review!
Support application/xhtml+xml executable MIME type in data URIs, and add corresponding positive and negative test cases. Co-authored-by: Aman Agnihotri <amanagnihotri902@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends
OpenRedirectOutputScorerto detect redirect parameters pointing to dangerous pseudo-protocols (javascript:,vbscript:, and executabledata:MIME types), including percent-encoded colons and MIME subtype separators._COLON,_SLASH,_PLUS, and_EXECUTABLE_DATA_MIME_TYPEShelpers (reusing_COLONinside_HTTP_SCHEME) and added"Pseudo-Protocol Redirect"toOpenRedirectOutputScorer._DEFAULT_PATTERNS.\s*(?:[\"']\s*)?to avoid quadratic whitespace backtracking and[^\s"']to prevent matching empty quoted protocols (redirect="javascript:"), while scopingdata:URIs to executable MIME types (text/html,image/svg+xml,javascript,ecmascript).OpenRedirectOutputScorerclass docstring to document pseudo-protocol redirect detection.test_open_redirect_output_scorer.pycovering raw/encodedjavascript:,vbscript:, executable/non-executabledata:URIs,;base64payloads, and prose exclusions.Demonstration
For
"https://example.com/login?redirect=javascript:alert(1)":score_value="false"(rationale:"")score_value="true"("Matched: Pseudo-Protocol Redirect")For
"https://example.com/login?url=data:image/png;base64,iVBORw0KGgo=":score_value="false"(rationale:"")Closes #4235