Repository navigation
FIX: filter legacy identifier layouts like the displayed attack type - #4287
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4282
The attack class and converter filters and the two options endpoints now read both stored identifier layouts. The SDK falls back to
children.attackfor rows written before the nested structure existed and displays their type, and analytics already resolves the same fallback, so:Tests and Documentation
A regression in
test_interface_attack_results.py, failing on main: a row stored with the legacy layout is found by its displayed attack class and its recorded converter, appears in both options lists, is kept by has_converters true, and stays out of has_converters false. The attack results, analytics metadata, and analytics suites pass (451 tests, apart from the preexisting operation id index case that fails identically on main). Ruff check and format are clean.No documentation change needed, so I did not run JupyText.