Fix python version - #333
Merged
Merged
Conversation
| #define mkdir(a) CreateDirectory(a, NULL) | ||
|
|
||
| #ifndef max | ||
| #define max(a,b) (((a) > (b)) ? (a) : (b)) |
Contributor
There was a problem hiding this comment.
I think we should prefer to use std::max, define this macro can cause some conflicts with other code
Member
Author
There was a problem hiding this comment.
this is required by dll compiling. It seems it cannot find the std::max.
| } | ||
| } | ||
|
|
||
| CallOnAppropriateBatch(handlers, readRequests, num, &DiskIO::BatchCleanRequests); |
Contributor
There was a problem hiding this comment.
We still need to clean requests in windows build, to release the refcounted buffers in internal implementation
Member
Author
There was a problem hiding this comment.
I have modified the DiskIO part so that let the diskio to clean the context instead of our library.
MaggieQi
requested review from
Philip Adams (PhilipBAdams) and
Guoxin (suiguoxin)
November 7, 2022 12:09
limenghao
approved these changes
Nov 30, 2022
L1ray (L1-ray)
pushed a commit
to L1-ray/SPTAG
that referenced
this pull request
May 9, 2026
* update python to python3 * use dynamic linking * enable ANNIndexTestTool code compiling * add python version in wheel package * update nuspec * enable to set different maxcheck and hashexponent * change to configure python version * trigger azurepipeline * trigger * fix python version * fix python version * fix python version in windows * fix cosine kmeans * clean avx/see header files * fix nuspec Co-authored-by: cheqi <cheqi@SRGSSD-07>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.