Fix GPU PQ build errors and added error checks - #334
Merged
Jie (Diego) Cai (caijiediego) merged 9 commits intoSep 27, 2022
Conversation
Jie (Diego) Cai (caijiediego)
previously approved these changes
Sep 23, 2022
Jie (Diego) Cai (caijiediego)
left a comment
Jie (Diego) Cai (caijiediego)
left a comment
Contributor
There was a problem hiding this comment.
Fixed GPU build break on both Linux and windows. Tested locally on windows.
Jie (Diego) Cai (caijiediego)
dismissed stale reviews from MaggieQi and themself
via
September 26, 2022 13:06
6242cff
Jie (Diego) Cai (caijiediego)
previously approved these changes
Sep 26, 2022
Jie (Diego) Cai (caijiediego)
left a comment
Jie (Diego) Cai (caijiediego)
left a comment
Contributor
There was a problem hiding this comment.
Try to trigger GitHub Test
Jie (Diego) Cai (caijiediego)
approved these changes
Sep 27, 2022
Jie (Diego) Cai (caijiediego)
left a comment
Jie (Diego) Cai (caijiediego)
left a comment
Contributor
There was a problem hiding this comment.
Approve
L1ray (L1-ray)
pushed a commit
to L1-ray/SPTAG
that referenced
this pull request
May 9, 2026
Fix GPU PQ build errors and added error checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several fixes to build issues with GPU PQ, including: