Skip to content

Fix windows build issues for GPU code - #346

Merged
MaggieQi merged 2 commits into
microsoft:mainfrom
bkarsin:win_typecheck_fix
Nov 17, 2022
Merged

Fix windows build issues for GPU code#346
MaggieQi merged 2 commits into
microsoft:mainfrom
bkarsin:win_typecheck_fix

Conversation

@bkarsin

Copy link
Copy Markdown
Contributor

Fixed two build issues with GPU code:

  • incorrect merge of code form previous PR caused duplicated function in TPTree.hxx
  • is_same_v not supported in windows, so changed to similar supported function

@MaggieQi
MaggieQi merged commit ebeb690 into microsoft:main Nov 17, 2022
L1ray (L1-ray) pushed a commit to L1-ray/SPTAG that referenced this pull request May 9, 2026
* Fix build issue and windows issue with is_same_v

* fix is_same_v error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants