Fix static initialization fiasco problem with the logger and code calling into it from other TUs - #358
Merged
Philip Adams (PhilipBAdams) merged 6 commits intoFeb 22, 2023
Conversation
Alexander Sklar (asklar)
changed the title
…de calling into it from other translation units
Alexander Sklar (asklar)
force-pushed
the
user/asklar/deferredLogger
branch
from
February 21, 2023 20:29
ad9e9d9 to
b797613
Compare
Philip Adams (PhilipBAdams)
approved these changes
Feb 22, 2023
L1ray (L1-ray)
pushed a commit
to L1-ray/SPTAG
that referenced
this pull request
May 9, 2026
…ling into it from other TUs (microsoft#358) * Addresses static initialization fiasco problem with the logger and code calling into it from other translation units * fix namespace * make logger init multithreading safe * actually we can use magic statics to simplify * Fix microsoft#356 * gate GMH/GPA on Windows only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently a dependency between the order of dynamic initializers for the logger and things that call into it, like CpuREP (see #356 for a related issue). This can result in crashes because the order of dynamic initializers across translation units is not deterministic in C++.
The fix is to access the logger via a function call that allows us to defer the logger initialization until it is needed (in a thread-safe manner). Using "magic statics" to do that.
An app will now be able to customize the log level (to suppress logging from dynamic initializers) by exporting a function with a certain name, which we will look up during
GetLogger():App code:
Fixes #356