Skip to content

refactor(naming): resource_verb owner tools, azure-cli-token module, --owning-app-client-id flag - #42

Open
gnjoseph wants to merge 1 commit into
feat/spe-mcp-serverfrom
agents/pr3-wi21-renames
Open

refactor(naming): resource_verb owner tools, azure-cli-token module, --owning-app-client-id flag#42
gnjoseph wants to merge 1 commit into
feat/spe-mcp-serverfrom
agents/pr3-wi21-renames

Conversation

@gnjoseph

@gnjoseph gnjoseph commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • A: Renamed owner MCP tools to the approved resource_verb convention: container_type_owner_grant and container_type_owner_delete, including exported symbols, registry/tests, docs, and catalog references.
  • B: Renamed the internal bootstrap module to azure-cli-token and updated getAzureCliToken, azureCliTokenProvider, and AzureCliToken terminology throughout source/tests.
  • C: Renamed CLI flag to --owning-app-client-id while keeping SPE_CLIENT_ID and a hidden deprecated --client-id alias for alpha back-compat.
  • D: Documented that container_type_create also registers the container type and, for standard billing, sets up billing prerequisites. The tool name/behavior are unchanged.

This follows the resource_verb decision from PR #3 review. The MCP tool-name changes are contract-breaking, but the package is still alpha/unpublished.

Validation

  • npm run lint
  • npm run typecheck
  • npm run build
  • npm test -- --reporter=dot --silent ✅ — 747 passed, 7 skipped (754)
  • Full-source grep: no dangling legacy owner tool names/symbols or bootstrap module references; only the hidden deprecated --client-id alias remains intentionally.

Adopt resource_verb owner tool names, rename the Azure CLI token module, update the owning app CLI flag, and clarify container_type_create scope per PR #3 review.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant