refactor(naming): resource_verb owner tools, azure-cli-token module, --owning-app-client-id flag - #42
Open
gnjoseph wants to merge 1 commit into
Open
refactor(naming): resource_verb owner tools, azure-cli-token module, --owning-app-client-id flag#42gnjoseph wants to merge 1 commit into
gnjoseph wants to merge 1 commit into
Conversation
Adopt resource_verb owner tool names, rename the Azure CLI token module, update the owning app CLI flag, and clarify container_type_create scope per PR #3 review. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
container_type_owner_grantandcontainer_type_owner_delete, including exported symbols, registry/tests, docs, and catalog references.bootstrapmodule toazure-cli-tokenand updatedgetAzureCliToken,azureCliTokenProvider, andAzureCliTokenterminology throughout source/tests.--owning-app-client-idwhile keepingSPE_CLIENT_IDand a hidden deprecated--client-idalias for alpha back-compat.container_type_createalso registers the container type and, for standard billing, sets up billing prerequisites. The tool name/behavior are unchanged.This follows the resource_verb decision from PR #3 review. The MCP tool-name changes are contract-breaking, but the package is still alpha/unpublished.
Validation
npm run lint✅npm run typecheck✅npm run build✅npm test -- --reporter=dot --silent✅ — 747 passed, 7 skipped (754)--client-idalias remains intentionally.