[Markdown] create documents in workspace - #2966
Merged
George Ng (GeorgeNgMsft) merged 4 commits intoSep 4, 2026
Merged
Conversation
George Ng (GeorgeNgMsft)
marked this pull request as ready for review
September 3, 2026 22:43
jebrans
approved these changes
Sep 4, 2026
jebrans
reviewed
Sep 4, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
George Ng (GeorgeNgMsft)
force-pushed
the
georgengmsft-markdown-workspace-create
branch
from
September 4, 2026 21:57
ba5ab44 to
d0f6e5f
Compare
Hillary Mutisya (hillary-mutisya)
pushed a commit
to hillary-mutisya/TypeAgent
that referenced
this pull request
Sep 10, 2026
## Stack Layer 3 of the replacement stack for microsoft#2940. - Base: `main` (microsoft#2966 and microsoft#2967 are merged) - Parent layer: microsoft#2967 (merged) ## Included - Persists headless Markdown updates directly to the authorized workspace file. - Makes streaming completion idempotent by recognizing the already-produced revision instead of applying operations twice. - Carries immutable binding identity and SHA-256 revision checks across read/apply. - Rejects stale tokens, rebound root/path/file identities, revision conflicts, and roots replaced by symlinks or junctions. - Adds request IDs to concurrent document read/apply IPC and correlates responses. - Keeps the view service server-authoritative for update persistence even when no browser/SSE client is connected. ## Deferred to browser layer - Browser `document-manager.ts` rewrite and serializer/autosave behavior. - Primary/secondary SSE lifecycle, browser synchronization/promotion UX, and reopening the same file while preserving browser binding state. - Broader browser snapshot adoption and loopback binding behavior. ## Validation Historical results from before the rebase (not rerun as full build/Jest validation): - `@typeagent/markdown-agent` TypeScript and frontend build - Focused Jest suites: 44 tests passed across Markdown persistence, operation engine, path policy, creation path policy, and action handler coverage - Prettier changed-file check - Git diff check - Repo lint ratchet After rebasing onto `f3e4308ea2cd722a2905eceac3f2a1e61d19a420`: 23 focused Node integration smoke checks passed using the actual handler, persistence module, and operation engine with simulated translator/view IPC; TypeScript 5.4.5 syntax parsing and Git diff checks passed. Full build/Jest, semantic typechecking, and repository ratchets were not rerun: this worktree has no installed dependencies (`fluid-build` missing). Pinned Prettier 3.5.3 was unavailable offline. Complete layer diff against the new main base: 992 insertions, 532 deletions (1,524 changed lines), across 6 files. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes document creation and separates open/create semantics
Layer 1 (bottom) of the replacement stack for #2940.
This layer adds only core workspace-safe Markdown document creation:
Deferred to upper layers
aiclientruntimeConfig/OpenAI changeValidation
pnpm run prettier:changed:fix/pnpm run prettier:changed(pass)baseline-browser-mapping@2.11.19anduuid@14.0.2because Azure Artifacts returned 401, leaving workspace package links incomplete; the resulting compiler errors were missing-module diagnostics