Speed up GHA workflows, use consistent bot token, etc#55923
Conversation
| else | ||
| npm test | ||
| npx hereby lkg | ||
| npx hereby LKG |
There was a problem hiding this comment.
What's the point of the LKG? Just as a test to see that it works?
There was a problem hiding this comment.
E.g. the LKG script silently broke because a dep updated, or something. Otherwise we wouldn't know until we attempted to do a release or nightly or something.
There was a problem hiding this comment.
(this particular change is just to make all of the workflows have the same casing; silly, I know)
| contents: write | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
do we want this to be v4 also?
There was a problem hiding this comment.
Surprisingly, this doesn't do a full fetch, so I don't need to bump it to get the new filter options.
I wanted to bump all of the versions but I'd need to update every file's version specifiers which felt noisy. Probably, we should enable dependabot but just for GHA. But either of those I'd rather in a different PR.
|
Thanks for sending this! I don't know the nuances of |
This should be safe; we already use that in the |
|
Any other concerns? |
An amalgamation of various fixups and improvements:
contents: write. When usingcontents: write, GHA workflows won't run when pushed as GHA tries to prevent loops by poisoning the token. A PAT works around this.sync-branch. This is slightly risky given baselines might fail, but I don't think we've seen that happen and @DanielRosenwasser reports that this delay is annoying.package-lock.jsonwhen changingpackage.json's version. This is harmless but generally annoying thatpackage-lockis not up to date on release branches. Honestly, I'm shocked thatnpm ciis okay with that state.update-lkg.yml, which could only ever update LKG on main, which I removed a while back.