Gate prefetch offload behind gvfs.prefetch-offload#2054
Merged
Conversation
tyrielv
force-pushed
the
tyrielv/flag-prefetch-offload
branch
from
July 9, 2026 23:18
10cceca to
b4c1f60
Compare
tyrielv
marked this pull request as ready for review
July 9, 2026 23:20
tyrielv
enabled auto-merge
July 9, 2026 23:20
KeithIsSleeping
approved these changes
Jul 13, 2026
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a disabled-by-default gvfs.prefetch-offload configuration flag and uses it to runtime-gate the existing mount-process prefetch offload paths so the default behavior remains the direct-auth flow. It also logs whether offload is enabled in prefetch telemetry metadata.
Changes:
- Add
gvfs.prefetch-offloadconfig key + default (false) constant. - Gate commit/blob prefetch offload-to-mount execution on
gvfs.prefetch-offload. - Emit
PrefetchOffloadEnabledas metadata on thePerformPrefetchrelated event.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
GVFS/GVFS/CommandLine/PrefetchVerb.cs |
Reads gvfs.prefetch-offload, records it in telemetry metadata, and gates mount-process offload paths on the flag. |
GVFS/GVFS.Common/GVFSConstants.cs |
Introduces GVFSConstants.GitConfig.PrefetchOffload and PrefetchOffloadDefault. |
GVFS/GVFS.UnitTests/Virtualization/FileSystemCallbacksTests.cs |
No functional change (diff appears to be formatting/line-number-only). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Default gvfs.prefetch-offload to false and skip mount offload runtime paths unless enabled. Add heartbeat FeatureFlags.PrefetchOffload telemetry and unit assertions. Assisted-by: GPT-5.3-Codex Copilot-Session: 85dced45-8638-4b33-a1d1-8af4c8e37fb0 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
The gvfs.prefetch-offload flag state is already captured fleet-wide by the git Trace2 collector via trace2.configparams (scalar.*,gvfs.*,...), surfaced as Summary.payload.params. Re-emitting it in VFS.Heartbeat is redundant and client-side telemetry adopts slowly across the GVFS fleet. Drop the FeatureFlags heartbeat metadata and the GitRepo.GetConfigBoolOrDefault wrapper added only to feed it. The gvfs.prefetch-offload gate in PrefetchVerb is unaffected. Assisted-by: Claude Opus 4.8 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tyrielv
force-pushed
the
tyrielv/flag-prefetch-offload
branch
from
July 14, 2026 23:36
c46b973 to
ee65930
Compare
KeithIsSleeping
approved these changes
Jul 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes