Gate CLI mount-progress display behind gvfs.mount-progress config#2055
Open
tyrielv wants to merge 1 commit into
Open
Gate CLI mount-progress display behind gvfs.mount-progress config#2055tyrielv wants to merge 1 commit into
tyrielv wants to merge 1 commit into
Conversation
PR microsoft#2005 restructured mount startup so the named pipe server starts before the parallel auth+validation wait. That early-pipe move is a reliability improvement -- it widens the WaitUntilMounted connect window, avoiding "GVFS.Mount process is not responding" failures when auth is slow (including the SYSTEM-service automount path) -- and is separable from the progress-display feature layered on top of it. Add a disabled-by-default gvfs.mount-progress config flag that gates only the display layer. When off, the mount process no longer surfaces MountProgress phase strings over the named pipe, and the CLI falls back to its existing static spinner (ConsoleHelper already renders just the base message when progress is empty). The reliability infrastructure -- early pipe start, HandleRequest Mounting-state guard, volatile currentState, and null-safe HandleGetStatusRequest -- is always on regardless of the flag, so stabilization builds keep the automount robustness without shipping the newer progress-display behavior. Assisted-by: Claude Opus 4.8 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
tyrielv
force-pushed
the
tyrielv/mount-progress-flag
branch
from
addd027 to
34666c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #2005 ("Show mount progress phases in CLI during gvfs mount") did two separable things:
Reliability infrastructure (must keep): moved the named-pipe server start before the parallel auth+validation wait in
InProcessMount.MountWithLockAcquired, plus aHandleRequestMounting-state guard,volatile currentState, and a null-safeHandleGetStatusRequest. Opening the pipe early widens theWaitUntilMountedconnect window: the"Unable to mount because the GVFS.Mount process is not responding"error only fires from the connect phase (60s interactive / 300s unattended); once connected, theGetStatuspoll loop is untimed. So an early pipe converts a possible connect-timeout into an indefinite-but-progressing wait. This benefits the SYSTEM-service automount path (GVFSMountProcessuses the sameWaitUntilMounted).Display layer (cosmetic): the
MountProgressphase strings + CLI dynamic spinner.Change
Adds a disabled-by-default
gvfs.mount-progressconfig flag that gates only the display layer:HandleGetStatusRequestno longer populatesresponse.MountProgress.WaitUntilMountedfires itsonProgresscallback only on non-empty progress, andConsoleHelperrenders just the base message when progress is empty — so the CLI falls back to its existing static spinner. No client-side changes needed.Mountingguard,volatile currentState, null-safeGetStatus) is always on, independent of the flag.Net effect for a stabilization prerelease: keep the automount robustness from #2005, hold back the newer progress-display behavior behind an opt-in (
git config gvfs.mount-progress true).Testing
dotnet build GVFS.Mount— clean (0 warnings, 0 errors)Notes
MountProcessSnapshot/TryConnectWithProcessTrackingearly-exit connect tracking is a separate change (commitd98a2bb9) and is intentionally untouched.