Scope ServiceVerbTests to a fixture-local GVFS service - #2059
Merged
Conversation
tyrielv
marked this pull request as ready for review
July 10, 2026 18:15
tyrielv
enabled auto-merge
July 10, 2026 18:15
Run ServiceVerbTests against a dedicated GVFS service name so --mount-all/--unmount-all only touch repos created in that fixture. This wires service-name overrides through functional-test helpers and adds fixture-local service lifecycle setup/teardown for ServiceVerbTests. Assisted-by: GPT-5.3-Codex Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
tyrielv
force-pushed
the
tyrielv/test-registry-scoping
branch
from
July 10, 2026 18:17
47683e8 to
f034ec7
Compare
Keith Klein (KeithIsSleeping)
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Tests for
gvfs service --mount-allandgvfs service --unmount-allcurrently can be flaky or cause flakiness in other tests because the service is system-scope. This PR changes the service scope to be a single test fixture while running functional tests.Summary
Validation
dotnet build GVFS/GVFS.FunctionalTests/GVFS.FunctionalTests.csproj -c DebugServiceVerbTests.ServiceCommandsWithNoRepos(blocked locally by existing ProgramData access denial while cleaningTest.GVFS.Servicelogs before tests start)