Fix build race condition in VS templates - #6413

Closed

Lauren Ciha (lauren-ciha) wants to merge 26 commits into

mainfrom

user/laurenciha/disable-template-build-button-during-package-install

Commits on Apr 17, 2026

First attempt at adding a build guard while packages are installing
Lauren Ciha (lauren-ciha)
committed
4c95ea5
Successful flow with Single-project, C# wapproj flow disabled all builds
Lauren Ciha (lauren-ciha)
committed
32a069b
Adds a check within build button handler to release build guard, after a number of manual tests, works with single-project C# and C#/C++ wapproj (not C# unit test)
Lauren Ciha (lauren-ciha)
committed
6f89e42
Add test explorer as a potential build command source for C# unit test templates
Lauren Ciha (lauren-ciha)
committed
1f9fc8d
Add auto-download setting check for smooth exit if disabled
Lauren Ciha (lauren-ciha)
committed
e0d6066
Add checks for if NuGetRestore is disabled
Lauren Ciha (lauren-ciha)
committed
f247d50
Add PackageReference fallback for C# projects
Lauren Ciha (lauren-ciha)
committed
c596799
Attempt to add an automatic package download not enabled dialog
Lauren Ciha (lauren-ciha)
committed
65c354d
C++ template shows infobar when auto download disabled
Lauren Ciha (lauren-ciha)
committed
23b44e0
Attempt to eliminate polling
Lauren Ciha (lauren-ciha)
committed
9ea5faf
Move polling into its own function
Lauren Ciha (lauren-ciha)
committed
40cd26e
Differentiate C++ message in InfoBar
Lauren Ciha (lauren-ciha)
committed
7a150da
Update infobar messages for auto-download disabled case
Lauren Ciha (lauren-ciha)
committed
2598c02
Fix BuildGuard logic so infobar shows when builds are attempted
Lauren Ciha (lauren-ciha)
committed
7ae5b8d
Disable the build guard infobar when build starts
Lauren Ciha (lauren-ciha)
committed
afb0a4d
Update BuildGuard infobar message to reflect that builds are paused and start after package installation
Lauren Ciha (lauren-ciha)
committed
38bdd27
Add header back to Designer files
Lauren Ciha (lauren-ciha)
committed
9b8cc4c
Link designer files in .csproj for C# and C++ templates
Lauren Ciha (lauren-ciha)
committed
5730d5a
Remove unused ShowAutomaticPackageDownloadNotEnabledErrorDialog() method
Lauren Ciha (lauren-ciha)
committed
49bf795
Remove activity in OnAfterOpenProjects - builds are disabled in RunStarted and the Unadvise call was premature
Lauren Ciha (lauren-ciha)
committed
46d9733
Remove SolutionBuildManager2 because we're targeting newer versions of VS
Lauren Ciha (lauren-ciha)
committed
7537758
Remove IVsUpdateSolutionEvents2 and its interfaces because they are no longer used
Lauren Ciha (lauren-ciha)
committed
20a5c92
Update instructions for auto-package instruction to enable both settings (resolves in one click instead of two)
Lauren Ciha (lauren-ciha)
committed
cf428ed
Add project null check in ProjectFinishedGenerating
Lauren Ciha (lauren-ciha)
committed
69d7cc8
Reset source.extension.vsixmanifests to GetVSIXVersion
Lauren Ciha (lauren-ciha)
committed
28dc0ab

Commits on Apr 21, 2026

Remove duplicate null check for _solutionBuildManager5
Lauren Ciha (lauren-ciha)
committed
56da5e1

Navigation Menu

Fix build race condition in VS templates - #6413

Fix build race condition in VS templates#6413
Lauren Ciha (lauren-ciha) wants to merge 26 commits into
mainfrom
user/laurenciha/disable-template-build-button-during-package-install

Commits on Apr 17, 2026

First attempt at adding a build guard while packages are installing

Successful flow with Single-project, C# wapproj flow disabled all builds

Adds a check within build button handler to release build guard, after a number of manual tests, works with single-project C# and C#/C++ wapproj (not C# unit test)

Add test explorer as a potential build command source for C# unit test templates

Add auto-download setting check for smooth exit if disabled

Add checks for if NuGetRestore is disabled

Add PackageReference fallback for C# projects

Attempt to add an automatic package download not enabled dialog

C++ template shows infobar when auto download disabled

Attempt to eliminate polling

Move polling into its own function

Differentiate C++ message in InfoBar

Update infobar messages for auto-download disabled case

Fix BuildGuard logic so infobar shows when builds are attempted

Disable the build guard infobar when build starts

Update BuildGuard infobar message to reflect that builds are paused and start after package installation

Add header back to Designer files

Link designer files in .csproj for C# and C++ templates

Remove unused ShowAutomaticPackageDownloadNotEnabledErrorDialog() method

Remove activity in OnAfterOpenProjects - builds are disabled in RunStarted and the Unadvise call was premature

Remove SolutionBuildManager2 because we're targeting newer versions of VS

Remove IVsUpdateSolutionEvents2 and its interfaces because they are no longer used

Update instructions for auto-package instruction to enable both settings (resolves in one click instead of two)

Add project null check in ProjectFinishedGenerating

Reset source.extension.vsixmanifests to GetVSIXVersion

Commits on Apr 21, 2026

Remove duplicate null check for _solutionBuildManager5