Skip to content

Improve Go API consistency review output - #820

Open
Ben Griffin (griffinbird) wants to merge 6 commits into
mainfrom
griffinbird-improve-parity-review-output
Open

Improve Go API consistency review output#820
Ben Griffin (griffinbird) wants to merge 6 commits into
mainfrom
griffinbird-improve-parity-review-output

Conversation

@griffinbird

@griffinbird Ben Griffin (griffinbird) commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Why

Make automated parity reviews faster for the Golang compiler team to verify and act on. The workflow now makes its scope and evidence explicit, and avoids low-confidence or duplicate inline comments.

Changes

  • Classify each review as public API, user-visible behavior, examples, and/or internal-only.
  • Require summary comments to include the changed Go contract, exact upstream .NET/Python evidence, and a clear result.
  • Require inline findings to cite the specific upstream source, symbol, test, or sample supporting the mismatch.
  • Limit inline findings to high-confidence, actionable issues.
  • Consolidate repeated instances of the same root cause into one representative comment with the complete affected scope.
  • Regenerate the workflow lock with the repository's existing gh-aw v0.83.4 baseline.

Impact

This does not change triggers, permissions, labels, required human approvals, or merge behavior. It improves the information available before the Golang compiler team performs its required review.

Validation

gh aw compile go-api-consistency-review --strict

Compilation completed successfully with 0 warnings.

Follow-up

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings August 10, 2026 06:42
@griffinbird
Ben Griffin (griffinbird) requested a review from a team as a code owner August 10, 2026 06:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Go API consistency review workflow guidance and regenerates the corresponding gh-aw lock artifacts to make automated parity reviews more explicit, evidence-driven, and actionable for maintainers.

Changes:

  • Tightens the review rubric to require scope classification, explicit upstream evidence, and high-confidence actionable findings.
  • Regenerates the compiled workflow lock file for gh-aw v0.85.4 (including updated runtime/tooling metadata).
  • Updates repository workflow/lock metadata files used by the automation.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/go-api-consistency-review.md Adds stricter parity-review process guidance (scope classification, upstream evidence citation, consolidation rules).
.github/workflows/go-api-consistency-review.lock.yml Regenerated compiled workflow lock output for gh-aw v0.85.4 with updated pinned tooling/metadata.
.github/aw/actions-lock.json Updates the pinned gh-aw setup action entry used by gh-aw metadata locking.
.gitattributes Adjusts how workflow lock files are treated by Git/Linguist.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .gitattributes Outdated
Comment on lines 1139 to 1143
runs-on: ubuntu-slim
permissions:
contents: read
actions: read
issues: write
pull-requests: write
Comment thread .github/aw/actions-lock.json Outdated
Comment on lines 8 to 12
"github/gh-aw-actions/setup@v0.85.4": {
"repo": "github/gh-aw-actions/setup",
"version": "v0.83.4",
"sha": "e89c65e17eb281bbd5ff2ff9e9199a03e96654c7"
"version": "v0.85.4",
"sha": "2709137ea6c5b0e19aa621454dc643ea8dc526b1"
}
@github-actions

This comment has been minimized.

Ben Griffin and others added 4 commits August 10, 2026 17:14
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Go API Consistency Review

Scope: internal-only (.github/ workflow files only)
Changed Go contract: None
Upstream evidence reviewed: N/A — no Go source changes
Result: Out of scope

This PR modifies only .github/workflows/go-api-consistency-review.md and the associated .lock.yml file. No exported Go APIs, user-visible behavior, or examples/ content were changed. Cross-repo parity review does not apply.

Generated by Go API Consistency Review Agent · sonnet46 · 10.7 AIC · ⌖ 4 AIC · ⊞ 6.1K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants