Skip to content

Upgrade OpenAI Go SDK to v3.54.0 - #952

Merged
George Adams (gdams) merged 2 commits into
mainfrom
fix/openai-go-v3.54-compat
Sep 1, 2026
Merged

Upgrade OpenAI Go SDK to v3.54.0#952
George Adams (gdams) merged 2 commits into
mainfrom
fix/openai-go-v3.54-compat

Conversation

@qmuntal

Copy link
Copy Markdown
Member

Summary

  • Upgrade github.com/openai/openai-go/v3 from v3.52.0 to v3.54.0.
  • Adapt Responses function-call outputs to the SDK's optional call_id API while preserving call correlation.
  • Update MCP error fixtures for the SDK's structured error representation.
  • Preserve Foundry project and agent-scoped routing under the SDK's stricter Azure authentication contract.

Partially supersedes #943 by extracting its OpenAI SDK upgrade and compatibility fixes. #943 still contains the remaining dependency updates.

Testing

  • go test ./provider/openaiprovider ./provider/foundryprovider -count=1
  • go mod tidy -diff
  • git diff --check

Copilot AI lite review requested due to automatic review settings August 31, 2026 14:54
@qmuntal
Quim Muntal (qmuntal) requested a review from a team as a code owner August 31, 2026 14:54
@github-actions github-actions Bot added area:provider Changes files in the provider area area:provider/foundry Changes files in the provider / foundry area area:provider/openai Changes files in the provider / openai area size:large At most 300 changed lines across at most 10 files labels Aug 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

Review tier: Lite
Findings: 2 Medium severity

New issues introduced by this change (2)
Severity Finding
Medium severity provider/​openaiprovider/​responses.gocall_id is optional in the Responses API; always setting it to an empty string can change request…
Medium severity provider/​foundryprovider/​agent.go — For Foundry project endpoints, api-version must be removed. Currently…
What changed in this PR

This PR upgrades the OpenAI Go SDK (github.com/openai/openai-go/v3) to v3.54.0 and updates the OpenAI Responses and Foundry providers to remain compatible with SDK changes around function-call correlation, MCP error shapes, and Azure authentication/endpoint behavior.

Changes:

  • Upgrade github.com/openai/openai-go/v3 from v3.52.0 to v3.54.0.
  • Add a helper to set Responses function-call output call_id (now optional in the SDK) and update call sites to preserve tool-call correlation.
  • Refactor Foundry agent client setup to satisfy the SDK’s stricter Azure endpoint/token-credential behavior while keeping Foundry routing and project/server-agent differences.
File Description
provider/​openaiprovider/​responses.go Adds helper for function-call output items and sets optional call_id for correlation.
provider/​openaiprovider/​responses_test.go Updates MCP error fixtures to match the SDK’s structured error representation.
provider/​foundryprovider/​agent.go Refactors Foundry OpenAI client setup (endpoint options + middleware) for SDK Azure contract changes.
provider/​foundryprovider/​agent_test.go Updates Foundry request assertions (api-version omission for project mode; User-Agent check).
go.mod Bumps OpenAI Go SDK dependency to v3.54.0.
go.sum Updates checksums (including new transitive deps).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread provider/openaiprovider/responses.go
Comment thread provider/foundryprovider/agent.go Outdated
@github-actions

This comment has been minimized.

@github-actions github-actions Bot added parity-approved Go API consistency review found no parity issues kind:code Changes production behavior or code kind:dependencies Changes dependencies or manifests kind:tests Changes tests, fixtures, or test infrastructure pending-auto-risk Automatic risk classification is in progress risk:medium Contained production impact requiring normal review depth and removed pending-auto-risk Automatic risk classification is in progress labels Aug 31, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Scope: internal-only
Changed Go contract: None — no exported types, functions, methods, fields, or options were added, removed, or modified
Upstream evidence reviewed: No equivalent found; this PR is a Go-specific dependency upgrade (OpenAI Go SDK v3.52.0 → v3.54.0) with no analogous change required in the .NET or Python implementations
Result: out of scope

This PR upgrades github.com/openai/openai-go/v3 and adapts private provider internals (responses.go, agent.go) to the new SDK contract. All changed symbols are unexported. No public Go API surface changed, and no parity comparison is needed. The parity-approved label is correct as-is.

Generated by Go API Consistency Review Agent for #952 · sonnet46 · 17.5 AIC · ⌖ 4.93 AIC · ⊞ 6.4K ·

@github-actions github-actions Bot added pending-auto-risk Automatic risk classification is in progress risk:medium Contained production impact requiring normal review depth and removed risk:medium Contained production impact requiring normal review depth pending-auto-risk Automatic risk classification is in progress labels Aug 31, 2026
@gdams
George Adams (gdams) added this pull request to the merge queue Sep 1, 2026
Merged via the queue into main with commit 4d26b2c Sep 1, 2026
36 checks passed
@gdams
George Adams (gdams) deleted the fix/openai-go-v3.54-compat branch September 1, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:provider/foundry Changes files in the provider / foundry area area:provider/openai Changes files in the provider / openai area area:provider Changes files in the provider area kind:code Changes production behavior or code kind:dependencies Changes dependencies or manifests kind:tests Changes tests, fixtures, or test infrastructure parity-approved Go API consistency review found no parity issues risk:medium Contained production impact requiring normal review depth size:large At most 300 changed lines across at most 10 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants