.NET: Use Random.GetString in hosting IdGenerator#2427
Merged
Conversation
stephentoub
temporarily deployed
to
integration
GitHub Actions
Inactive
stephentoub
temporarily deployed
to
integration
GitHub Actions
Inactive
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes ID generation by using the built-in Random.GetString() method for .NET 10+ instead of manually creating random strings with string.Create(). This simplifies the code and leverages framework optimizations for better performance.
- Uses conditional compilation to call
Random.GetString()when available - Maintains backward compatibility with older .NET versions using the existing
string.Create()implementation - Preserves the deterministic random generation behavior when a seed is provided
crickman
approved these changes
Nov 24, 2025
rogerbarreto
approved these changes
Nov 25, 2025
This was referenced Dec 5, 2025
This was referenced Dec 22, 2025
This was referenced Jan 9, 2026
This was referenced Jan 19, 2026
This was referenced Jan 28, 2026
arisng
pushed a commit
to arisng/agent-framework
that referenced
this pull request
Feb 2, 2026
This was referenced Mar 2, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.