.NET: Fixed CA1873 warning#4634
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an explicit debug-level guard around the “summarization starting” log call in the .NET compaction strategy, reducing overhead when debug logging is disabled.
Changes:
- Wrap
LogSummarizationStarting(...)withlogger.IsEnabled(LogLevel.Debug).
You can also share your feedback on Copilot code review. Take the survey.
moonbox3
approved these changes
Mar 11, 2026
TaoChenOSU
approved these changes
Mar 11, 2026
This was referenced Mar 13, 2026
This was referenced Mar 23, 2026
This was referenced Apr 7, 2026
This was referenced Apr 17, 2026
This was referenced May 2, 2026
This was referenced May 9, 2026
Closed
Closed
This was referenced May 18, 2026
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.