Skip to content

.NET: tests: removes dependency on fluent assersion because of licensing concerns - #7938

Merged
Vincent Biret (baywet) merged 7 commits into
mainfrom
chore/strip-fa-dotnet
Aug 31, 2026
Merged

.NET: tests: removes dependency on fluent assersion because of licensing concerns#7938
Vincent Biret (baywet) merged 7 commits into
mainfrom
chore/strip-fa-dotnet

Conversation

@baywet

@baywet Vincent Biret (baywet) commented Aug 28, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI balanced review requested due to automatic review settings August 28, 2026 17:40
@agent-framework-automation agent-framework-automation Bot added the .NET Usage: [Issues, PRs], Target: .Net label Aug 28, 2026
@github-actions github-actions Bot changed the title tests: removes dependency on fluent assersion because of licensing concerns .NET: tests: removes dependency on fluent assersion because of licensing concerns Aug 28, 2026

This comment was marked as outdated.

Sign in to view

@baywet
fix: preserve xunit assertion coverage
efc0c5f 
Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>

This comment was marked as outdated.

Sign in to view
Yashvant Mahadev Hange (YashvantHange) added a commit to YashvantHange/agent-framework that referenced this pull request Sep 4, 2026
@YashvantHange
.NET: rewrite the approval tests in xUnit and withhold first-wins
63afe94 
microsoft#7938 removed FluentAssertions from the tree over licensing and rewrote the
other tests in this project, so the assertions added here no longer compiled
once main was merged in. The merge was clean because neither side touched the
same lines: main deleted the using and the package reference, this branch only
added Should() calls under them.

Also make the withheld-approval map first-wins. A repeated request ID keeps
its first occurrence everywhere else that answers the same question, so
overwriting here would re-emit the copy that was displaced and show the caller
a request the workflow had discarded. It cannot be reached on this branch,
where a duplicate request ID still throws, but it is reachable as soon as
first-wins coalescing lands beside it.
Yashvant Mahadev Hange (YashvantHange) added a commit to YashvantHange/agent-framework that referenced this pull request Sep 4, 2026
@YashvantHange
.NET: rewrite the coalescing tests in xUnit
102bf3e 
microsoft#7938 removed FluentAssertions from the tree over licensing and rewrote the
other tests in this project, so the assertions added here no longer compiled
once main was merged in. The merge was clean because neither side touched the
same lines: main deleted the using and the package reference, this branch only
added Should() calls under them. The because strings become comments, which is
what the rest of the project does now.

Also record why handoff target selection stays last-wins while the coalescing
beside it is first-wins. The two answer different questions, and with the
re-emission filter in front of it the selection only ever sees genuinely
competing targets.
This was referenced Sep 4, 2026
Open
Open
Open
This was referenced Sep 5, 2026
Open
Open
Closed
Open
Merged
Open
Open
Merged
Open
Merged
Closed
Open
Open
Closed
Open
Open
Closed
Merged
Open
Merged
Open
Open
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
Copilot code review Copilot Copilot left review comments
@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes
@chetantoshniwal chetantoshniwal Awaiting requested review from chetantoshniwal chetantoshniwal is a code owner
@peibekwe Peter Ibekwe (peibekwe) Awaiting requested review from peibekwe peibekwe is a code owner
@rogerbarreto Roger Barreto (rogerbarreto) Awaiting requested review from rogerbarreto rogerbarreto is a code owner
@westey-m westey (westey-m) Awaiting requested review from westey-m westey-m is a code owner

Assignees

@baywet Vincent Biret (baywet)

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@baywet @SergeyMenshykh