Repository navigation
[docs] AzureRoleAssignmentResource is no longer experimental - #1861
Closed
aspire-repo-bot[bot] wants to merge 1 commit into
Closed
aspire-repo-bot[bot] wants to merge 1 commit into
aspire-repo-bot[bot] wants to merge 1 commit into
Conversation
…URE003) Documents microsoft/aspire#20857: AzureRoleAssignmentResource no longer requires suppressing ASPIREAZURE003, since Azure role assignments aren't an Azure Virtual Network feature. Updates the ASPIREAZURE003 diagnostic page, the role-assignments integration guide, and adds a What's new in Aspire 17.0 entry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
aspire-repo-bot
Bot
added
the
docs-from-code
4 of 14 tasks
Contributor
Author
Frontend HTML artifact readyThe latest frontend build uploaded the This comment updates automatically when a new frontend build artifact is uploaded. |
Comment on lines
+20
to
+23
| :::note | ||
| Starting in Aspire 17.0, `AzureRoleAssignmentResource` no longer reports `ASPIREAZURE003`. Role assignments aren't an Azure Virtual Network feature, so this diagnostic only applies to the networking types, such as `AddAzureVirtualNetwork` and `AddSubnet`. For more information, see [Manage Azure role assignments](/integrations/cloud/azure/role-assignments/#inspect-role-assignments-programmatically). | ||
| ::: | ||
|
|
There was a problem hiding this comment.
Suggested change
| :::note | |
| Starting in Aspire 17.0, `AzureRoleAssignmentResource` no longer reports `ASPIREAZURE003`. Role assignments aren't an Azure Virtual Network feature, so this diagnostic only applies to the networking types, such as `AddAzureVirtualNetwork` and `AddSubnet`. For more information, see [Manage Azure role assignments](/integrations/cloud/azure/role-assignments/#inspect-role-assignments-programmatically). | |
| ::: |
Member
|
This change isn't worth updating docs. We were using the wrong diagnostic ID from the beginning - 003 should have only been about azure networking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents changes from microsoft/aspire#20857
@eerhardtTarget branch
Targeting
release/17.0based on the source PR milestone17.0.Why this is needed
microsoft/aspire#20857 removes the
[Experimental("ASPIREAZURE003")]attribute fromAzureRoleAssignmentResourceand cleans up the now-obsolete#pragma warning disable ASPIREAZURE003suppressions inRoleAssignmentResourceAnnotation, the shared ACR pull identity helper, and role-assignment tests. Azure role assignments aren't an Azure Virtual Network feature, so the networking experimental diagnostic shouldn't have applied to this type. Consumers can now inspectAzureRoleAssignmentResourceinstances (for example, in pipeline steps) without suppressingASPIREAZURE003. Runtime provisioning and authorization behavior are unchanged.ReferenceRoleAssignmentAnnotationremains experimental underASPIREAZURE003and was not affected by this PR.The docs site had no mention of this change, so a docs update is required.
What changed
diagnostics/aspireazure003.mdx: Added a note clarifying that, starting in Aspire 17.0,AzureRoleAssignmentResourceno longer reportsASPIREAZURE003, and that the diagnostic now only applies to the Azure Virtual Network types (AddAzureVirtualNetwork,AddSubnet, etc.).integrations/cloud/azure/role-assignments.mdx: Added a sentence in the "Inspect role assignments programmatically" section noting thatAzureRoleAssignmentResourceno longer requires suppressingASPIREAZURE003.whats-new/aspire-17.mdx: Added a new "App model and AppHost" section with a "AzureRoleAssignmentResourceis no longer experimental" entry, including a short code example (copied from the source PR's "User-facing usage" section) and a cross-reference to the role-assignments guide.Files modified
src/frontend/src/content/docs/diagnostics/aspireazure003.mdx(updated)src/frontend/src/content/docs/integrations/cloud/azure/role-assignments.mdx(updated)src/frontend/src/content/docs/whats-new/aspire-17.mdx(updated)No new pages were created; all changes are updates to existing pages.