Repository navigation
[Track2 #2] Migrate nodes in Azure explorer to app service library - #4972
Merged
Hanxiao Liu (Flanker32) merged 7 commits intoMar 10, 2021
Merged
Conversation
Hanxiao Liu (Flanker32)
changed the title
| WebAppUtils.WebAppDetails webAppDetails = (WebAppUtils.WebAppDetails) event.object; | ||
| switch (event.opsType) { | ||
| case ADD: | ||
| final IWebApp newWebApp = AzureWebAppMvpModel.getInstance() |
Contributor
There was a problem hiding this comment.
Why shall we use AzureWebAppMvpModel, shall we use az.webapp(id)?
Member
Author
There was a problem hiding this comment.
Will update codes here after refactor app service library to leverage Account service for authentication
|
|
||
| private final WebApp webapp; | ||
| // todo: migrate file service to track2 SDK | ||
| private final WebApp webapp; // Track one client, keep for file service |
Contributor
There was a problem hiding this comment.
can we lazy load the webapp since the following statement will cause a network call.
AzureWebAppMvpModel.getInstance().getWebAppById(subscriptionId, webAppManager.id());
| @Override | ||
| public @Nullable AzureIconSymbol getIconSymbol() { | ||
| boolean isLinux = OperatingSystem.LINUX.name().equalsIgnoreCase(webapp.operatingSystem().toString()); | ||
| boolean isLinux = webapp.getRuntime().getOperatingSystem() != OperatingSystem.WINDOWS; |
Contributor
There was a problem hiding this comment.
add isLinux in IWebapp
| private final IWebAppDeploymentSlot slot; | ||
|
|
||
| public DeploymentSlotNode(final IWebAppDeploymentSlot deploymentSlot, final DeploymentSlotModule parent) { | ||
| super(deploymentSlot.id(), deploymentSlot.name(), LABEL, parent, parent.subscriptionId, deploymentSlot.hostName(), |
| * todo: move to app service library | ||
| */ | ||
| @AzureOperation( | ||
| name = "webapp.list.subscription|selected", |
| @@ -6,12 +6,25 @@ | |||
| package com.microsoft.azuretools.core.mvp.model.webapp; | |||
Contributor
There was a problem hiding this comment.
deprecate anno
Andy Xu(devdiv) (andxu)
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate nodes in Azure explorer to app service library