React Native 0.66 Update

[Nabil Khalil (nabil-k)]

Platforms Impacted

• iOS
• macOS
• win32 (Office)
• windows
• android

This PR is based on the changes from #1511

Platform Status

• Win32: Good, no known issues at the moment.
• Windows: Good, no known issues at the moment.
  • It actually runs better than it's RN 0.64 counterpart. On RN 0.64 when switching pages you would get a render error that says Cannot redefine non-configurable property. However, after updating everything to RN 0.66, I haven't gotten that error at all.
• MacOs: Good, no known issues at the moment.
• iOS: Good, no known issues at the moment.
• Android: Good, no known issues at the moment.

Description of Changes

These are just changes I've made to get further through the build process. This is just to help everyone be aware of some changes that have occurred between RN 0.64 and RN 0.66.

General

packages/utils/adapters/src/adapters
For RN 0.66 Typescript, two new props on TextProps have been added called onPressIn and onPressOut.

Windows

packages/theming/theming-utils/src/getCurrentAppearance.windows.ts
Removed !AppTheme.isAvailable, causes a type error.

Win32

packages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts
Removed declaring TurboModuleRegistry in a react native module.

Verification

(how the change was tested, including both manual and automated tests)

Pull request checklist

This PR has considered (when applicable):

• Automated Tests
• Documentation and examples
• Keyboard Accessibility
• Voiceover
• Internationalization and Right-to-left Layouts

[Samuel Freiberg (samuelfreiberg)]

"This is not meant to be merged as it currently stands." I think we should make this a Draft PR if it's not meant to be merged and there's a lot of work left (just so the intent is clear).

[Saad Najmi (Saadnajmi)]

If you're feeling fancy, you could update it so that every package.json has an rnx-kit config and future version upgrades are a simple one-line rnx-dep-check --write. Totally not required though :)

[Nabil Khalil (nabil-k)]

Ruriko Araki (@rurikoaraki) Yeah I think we should, I tested the onPressIn/Out prop and it works on all platform. I've added it, thanks!

[Saad Najmi (Saadnajmi)]

Minor note:
I think the test apps still specify "react-test-renderer": "17.0.1". That should probably be "17.0.2"

[Nabil Khalil (nabil-k)]

This PR causes this issue where Shadow is unable to pass the Jest tests due to an error "Invariant Violation: __fbBatchedBridgeConfig is not set, cannot invoke native modules"

[Andrew Dewar (Dewsk)]

Nabil - great job here! We're really close to being ready to merge and this was a large cross-platform ask. I think we have some cool stories to tell about it and I've been really impressed with how diligently you've worked through all the tricky platform unique issues.

[Andrew Dewar (Dewsk)]

We are good to merge this!

[Ruriko Araki (rurikoaraki)]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).