Skip to content

Fix typo in DirectionalHint Callout type - #3648

Open
Lawrence Win (lawrencewin) wants to merge 3 commits into
microsoft:mainfrom
lawrencewin:callout-typo-fix
Open

Fix typo in DirectionalHint Callout type#3648
Lawrence Win (lawrencewin) wants to merge 3 commits into
microsoft:mainfrom
lawrencewin:callout-typo-fix

Conversation

@lawrencewin

@lawrencewin Lawrence Win (lawrencewin) commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

There's a typo in the DirectionalHint type for Callout's directionalHint prop, where "bottomLeftEdge" is spelled as "bottonLeftEdge". This PR fixes this so the linter stops spitting an incorrect error.

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@lawrencewin
Lawrence Win (lawrencewin) enabled auto-merge (squash) June 7, 2024 21:21

@Saadnajmi Saad Najmi (Saadnajmi) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saadnajmi

Copy link
Copy Markdown
Collaborator

Which.. after that, we'll have to ensure that the change makes it internally and doesn't cause regressions for partners who don't update their bundles..

@PPatBoyd

Copy link
Copy Markdown
Contributor

Which.. after that, we'll have to ensure that the change makes it internally and doesn't cause regressions for partners who don't update their bundles..

FWIW there are no current users of the enum value that I could find in any Office repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants